Ticket #7926 (closed: fixed)
[IDA] ConvFit - Add Additional Sample Logs
| Reported by: | Samuel Jackson | Owned by: | Samuel Jackson |
|---|---|---|---|
| Priority: | major | Milestone: | Release 3.0 |
| Component: | Indirect Inelastic | Keywords: | |
| Cc: | spencer.howells@… | Blocked By: | |
| Blocking: | #5421, #7966 | Tester: | Peter Parker |
Description
Update from Spencer. AddSampleLogs to a couple of places in the ConvFit routine. This will help with the creation of the indirect bayes interface.
Change History
comment:2 Changed 7 years ago by Samuel Jackson
- Status changed from inprogress to verify
- Resolution set to fixed
comment:3 Changed 7 years ago by Samuel Jackson
To Tester
Run a sequential ConvFit using instructions found here: http://www.mantidproject.org/Indirect:Indirect_Data_Analysis#Running_ConvFit
Check that the sample logs for fit program, delta and background are present in each of the result workspaces in the workspace group.
comment:4 Changed 7 years ago by Samuel Jackson
- Status changed from verify to reopened
- Resolution fixed deleted
comment:5 Changed 7 years ago by Samuel Jackson
Spencer has flagged up that there is an additional workspace that requires the logs to be added.
comment:6 Changed 7 years ago by Samuel Jackson
- Status changed from reopened to inprogress
Refs #7926 Adding sample logs to other workspace.
Changeset: c54c1986095c49757903e6258ab34ab47e025f1b
comment:8 Changed 7 years ago by Samuel Jackson
- Status changed from inprogress to verify
- Resolution set to fixed
To Tester
In addition to the above, also check that the same logs are appearing in the *_Workspace workspace.
comment:9 Changed 7 years ago by Samuel Jackson
- Status changed from verify to reopened
- Resolution fixed deleted
comment:10 Changed 7 years ago by Samuel Jackson
- Status changed from reopened to inprogress
Refs #7926 Bugfix for getting options in ConvFit.
Changeset: 0376671571e0e48af13f7791bb41f58af202780c
comment:11 Changed 7 years ago by Samuel Jackson
- Status changed from inprogress to verify
- Resolution set to fixed
comment:12 Changed 7 years ago by Nick Draper
- Status changed from verify to verifying
- Tester set to Nick Draper
comment:13 follow-up: ↓ 14 Changed 7 years ago by Nick Draper
- Status changed from verifying to reopened
- Resolution fixed deleted
The sample logs listed are:
- run_title
- Lorentzians
- Fit Program
- Delta
- Background
However there is no energy min and energy max values
Therefore Fail
comment:14 in reply to: ↑ 13 Changed 7 years ago by Samuel Jackson
- Status changed from reopened to verify
- Resolution set to fixed
Sorry Nick, ticket #7965 should be Fit, energy min and max. This one should be Fit, background and delta. My mistake by copy & pasting from the other ticket.
Replying to Nick Draper:
The sample logs listed are:
- run_title
- Lorentzians
- Fit Program
- Delta
- Background
However there is no energy min and energy max values
Therefore Fail
comment:15 Changed 7 years ago by Peter Parker
- Status changed from verify to verifying
- Tester changed from Nick Draper to Peter Parker
comment:16 Changed 7 years ago by Peter Parker
- Status changed from verifying to closed
Merge remote-tracking branch 'origin/feature/7926_add_sample_logs'
Full changeset: 0c9d45d4b071cfbd158608faedf5685a6b0ec5fc
comment:17 Changed 7 years ago by Peter Parker
The sample logs for the result workspaces do indeed have entries for Fit Program, Delta and Background. There is also a Lorentzians entry.
Passing.
comment:18 Changed 7 years ago by Nick Draper
- Component changed from Framework to Indirect Inelastic
comment:19 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 8771
Refs #7926 Adding sample logs to ConvFit.
Changeset: dccc055414df62a7170484e7e7d768973f4de0d9