Ticket #8376 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

BinMD gui need to be looked at

Reported by: Owen Arnold Owned by: Owen Arnold
Priority: major Milestone: Release 3.2
Component: Diffraction Keywords:
Cc: Blocked By:
Blocking: Tester: Michael Reuter

Description (last modified by Owen Arnold) (diff)

Email from Paz

Sometime you want to repeat the same cut on many runs (same position different temperatures/fields). I cannot see the autocomplete features.


From: Arnold, Owen (Tessella,RAL,ISIS)
Sent: 28 October 2013 9:04 AM
To: Manuel, Pascal (STFC,RAL,ISIS); Mantid Help
Subject: Re: [Mantid-help] BinMD

Hi,

BinMD will refresh it's inputs every time a new workspace is chosen. This behaviour is slightly different to that for many other algorithm dialogs as it gives better autocomplete for the dimensions. It might be best for me to take a look at how you are using this algorithm dialog in the context of your workflow.


From: "pascal.manuel@stfc.ac.uk" <pascal.manuel@stfc.ac.uk>
Date: Sunday, 27 October 2013 12:07
To: Mantid Help <mantid-help@mantidproject.org>
Subject: [Mantid-help] BinMD

It looks like it is not remembering the cuts you choose on previous occasions (extents yes but axes no).

1-2 days worth of work depending upon the complexity.

Change History

comment:1 Changed 7 years ago by Owen Arnold

  • Description modified (diff)

comment:2 Changed 7 years ago by Nick Draper

  • Milestone changed from Release 3.1 to Backlog

Moved to backlog at the end of Release 3.1

comment:3 Changed 7 years ago by Owen Arnold

  • Milestone changed from Backlog to Release 3.2

comment:4 Changed 7 years ago by Nick Draper

  • Status changed from new to assigned

Bulk move of tickets out of triage (new) to assigned at the introduction of the triage state

comment:5 Changed 7 years ago by Owen Arnold

refs #8376. Problem fixed.

Although, I'd like to do some more refactoring to neaten things up before hand.

Changeset: 80602330c0bb156c1abffeabf41f46a8212f647f

comment:6 Changed 7 years ago by Owen Arnold

  • Status changed from assigned to inprogress

refs #8376. Some minor refactoring steps.

Changeset: c6325aca8a355e18bb6e53fd0e23e20d305c1fd9

comment:7 Changed 7 years ago by Owen Arnold

refs #8376. More refactoring.

Changeset: dc3c14dbdfb83e7746dd0a8d22fd42928b19a63c

comment:8 Changed 7 years ago by Owen Arnold

Tester: Use the following python script to setup some input workspaces.

CreateMDWorkspace(Dimensions='2',EventType='MDEvent',Extents='-10,10,-10,10',Names='Q_lab_x,Q_lab_y',Units='A,B',OutputWorkspace='test1')
FakeMDEventData(InputWorkspace='test1',UniformParams='1000',PeakParams='100000,0,0,1')
test2 = SliceMD(InputWorkspace='test1',AxisAligned='0',BasisVector0='X,units,0.888154,0.459545',BasisVector1='Y,units,-0.459545,0.888154',Translation='-4.93562,-2.3918',OutputExtents='0,9.61632,-0.1,0.1',OutputBins='100,1')
  1. Start BinMD and select input workspace to be 'test1'
  2. Check that. 'Always Calculate Extents' check box should be off by default.
  3. Ensure that 'Axis Aligned' is selected and hit the 'Calculate Extents'. This should enter values for the the binning of each dimension.
  4. Enter the name for an output workspace and run the algorithm. It should run without issue.
  5. Now reopen BinMD and change the input workspace. It should have remembered the inputs from the last execution.
  6. Switch the input workspace to 'test2'. The dimension entries should NOT change.
  7. Run the algorithm and it SHOULD fail to execute indicating that the dimension information is incorrect for this workspace
  8. Now hit 'Calculate Extents' and the dimension information should be recalculated. Now running the algorithm should work as expected.
  9. Repeat the steps above for the SliceMD algorithm dialog. The behaviour should be the same.
  10. Now check 'Always Calculate Extents' and execute either BinMD or SliceMD. It should execute and create your output workspace.
  11. Reopen the algorithm dialog just execute and note that Always Calculate Extents should still be checked.
  12. With the dialog still open, change the input workspace and the axis aligned dimension info should automatically update.

comment:9 Changed 7 years ago by Owen Arnold

  • Status changed from inprogress to verify
  • Resolution set to fixed

comment:10 Changed 7 years ago by Michael Reuter

  • Status changed from verify to verifying
  • Tester set to Michael Reuter

comment:11 Changed 7 years ago by Michael Reuter

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/feature/8376_binmd_gui'

Full changeset: b058476c004c968100bb1571dfda9d0da4184f09

comment:12 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 9221

Note: See TracTickets for help on using tickets.