Ticket #8591 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

Move helper function to anonymous namespace to avoid potential linker problems

Reported by: Peter Parker Owned by: Owen Arnold
Priority: trivial Milestone: Release 3.1
Component: Reflectometry Keywords:
Cc: Blocked By:
Blocking: Tester: Russell Taylor

Description

The checkNotPositive helper function in Algorithms\src\ReflectometryReductionOne.cpp.

Change History

comment:1 Changed 7 years ago by Martyn Gigg

There is also a compiler warning that was introduced in #8371 that needs ​addressing

Last edited 7 years ago by Martyn Gigg (previous) (diff)

comment:2 Changed 7 years ago by Owen Arnold

  • Status changed from new to inprogress

refs #8591. Move helper and apply warning fix.

Changeset: 72cb56f69d983c3ec1134ce0fa86796c4ed15661

comment:3 Changed 7 years ago by Owen Arnold

  • Status changed from inprogress to verify
  • Resolution set to fixed

comment:4 Changed 7 years ago by Russell Taylor

  • Status changed from verify to verifying
  • Tester set to Russell Taylor
  • Milestone changed from Backlog to Release 3.1

comment:5 Changed 7 years ago by Russell Taylor

  • Status changed from verifying to closed

Merge remote branch 'origin/feature/8591_helper_and_fixes'

Full changeset: ​b370a24ade8fb18989295b14c9b49cd37dade5d1

comment:6 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​9435

Note: See TracTickets for help on using tickets.