Tiled Graph Displays

[Nick Draper]

A window of tiled graphs (or static instrument views)

• options to remove, sort or pop the graph as a larger window.
• Could be considered as a collection of your graphs

Notes from Estimation

Improve general layer handling
Different plot types in tiles (1d plots, 2d plots, inst view, slice viewer)
Expand selected windows
Rearrange order/ add,delete - drag drop
Format single+many internal plots
Command interface - creating tiled display from python ,get handles of plots"	

Include reportlab stuff?

[Nick Draper]

Bulk move of tickets out of triage (new) to assigned at the introduction of the triage state

[Roman Tolchenov]

Re #8909. Detached MdiSubWindow from ApplicationWindow

Changeset: b2808465f4181b450b72da924bffdb325e8bf7a9

[Roman Tolchenov]

Merge branch 'master' into feature/8909_tiled_graph_displays

Conflicts:

Code/Mantid/MantidPlot/src/MdiSubWindow.cpp Code/Mantid/MantidPlot/src/MdiSubWindow.h

Re #8909

Changeset: 1420469c301b84590e4204e9b941c59912061cef

[Roman Tolchenov]

Re #8909. Added TiledWindow window class

Changeset: 29a0c887c05c28bb941a666c42cee2df7c912d01

[Roman Tolchenov]

Re #8909. Use EmptyTile widgets to fill in empty spaces.

Changeset: 080e0ab01e87f061df8ee928bf5ac56d9e945a03

[Roman Tolchenov]

Re #8909. Added selection of tiles.

Changeset: 3d72d4d3fc228c1ed62a06dfaee6429c3ba79872

[Roman Tolchenov]

Re #8909. More visible border for selected tiles.

Changeset: 94cb2a6f611689f2253b58ade78c75122bda165a

[Roman Tolchenov]

Re #8909. Added range selection with a mouse.

Changeset: 0c9514790749599bbb5adf91092e4789a7df65b5

[Roman Tolchenov]

Re #8909. Selection, deselection and removing ranges of widgets.

Changeset: b80cd677087f328d37f0701f557578d260098209

[Roman Tolchenov]

Re #8909. Implemented window reshaping.

Changeset: 316647958a99eca1fab4e70c3f78a75208db1edb

[Roman Tolchenov]

Re #8909. Added a menu for tiled windows.

Changeset: c77cbfda71680e9df89dfccd0a7737d5b1d4b464

[Roman Tolchenov]

Re #8909. Implemented dragging and dropping of floating windows

Changeset: 58bb952452b41b46e97c5fe3a670a6484ea2efb2

[Roman Tolchenov]

Re #8909. Added drag and drop of floating graphs to TiledWindow.

Changeset: 019fe9166283e5abbb2f121fedf622b960a08a01

[Roman Tolchenov]

Re #8909. Removing widgets from TiledWindow with drag and drop.

Changeset: 363c31e5f1f08592e20b274a4378ec747d905e8b

[Roman Tolchenov]

Re #8909. Dragging graphs from docked windows, and to floating tiled windows.

Changeset: 2092b46e892e06f5d55147a422061047ee2868b9

[Roman Tolchenov]

Re #8909. Marking insertion position between tiles.

Changeset: 34e0cd73675f4ad74e2b9b58127fbca4afa4d404

[Roman Tolchenov]

Merge branch 'master' into feature/8909_tiled_graph_displays

Conflicts:

Code/Mantid/MantidPlot/src/ApplicationWindow.cpp

Re #8909

Changeset: 8c4a0526a8ce3d78903e36180ed7f9fa50977eb7

[Roman Tolchenov]

Merge branch 'master' into feature/8909_tiled_graph_displays

Conflicts:

Code/Mantid/MantidPlot/CMakeLists.txt

Re #8909.

Changeset: 43f52b3b42ec7b24548643f8f4bf0016636e499c

[Roman Tolchenov]

Re #8909. Widgets can be inserted into TiledWindows.

Changeset: 1ff42cb51bf3d4809ab7f24b2f555b221be9e932

[Roman Tolchenov]

Re #8909. Fixes to TiledWindow reshaping and moving widgets.

Updated python interface. Added new tests.

Changeset: 8d7faee0b4faf84b94860311e7f166dc24d032a2

[Roman Tolchenov]

Re #8909. Fixed compiler warnings.

Changeset: 9b8aeb4e3fc435f06b5a2f88b236f88c6968a489

[Roman Tolchenov]

To tester

1. See MantidPlot/test/MantidPlotTiledWindowTest.py for examples of usage.
2. Create a new TiledWindow form File->New... menu.
3. Drag and drop graphs and other windows on the TiledWindow. Graphs can be dragged by the canvas (graph's inside). To insert other windows make them floating then move them (by the title bar) on top of the TiledWindow.
4. Check tile selection: left click selects a single tile, Ctrl+click adds a tile to the selection, Shift+click selects a range.
5. Check removing tiles by dragging the selection off the window.
6. Check dragging tiles inside the window.
7. Check main menu's "Tiled Window" commands.
8. Check python usage.

[Karl Palmen]

git test review did not work for me, so I'm doing the code review by looking at the commits of this ticket. One commit did not display because of the large number (752) files changed.

[Karl Palmen]

Partial code review suggests that the coding changes were good.

[Karl Palmen]

Tiled windows worked as expected, except that it did crash when I tested 'clear' having done many things to the tile window. I couldn't reproduce this crash on 'clear' in a simple scenario, so I'm going to pass the ticket and leave the crash on clear to the random testing.

[Karl Palmen]

I've tested this on Windows.

I think it needs testing on non-Windows systems, so will return the ticket to the testing pool for testing on other systems.

[Nick Draper]

Reopened to deal with crash

[Roman Tolchenov]

Re #8909. Fixed a crash caused by TiledWindow's clear() method.

Changeset: fb5bc9ac9f9c259e7b70779d1e86688ee787544b

[Karl Palmen]

No crash after trying similar to before. I return to testing pool for testing on non-windows systems.

[Samuel Jackson]

I get a segmentation fault if I create a new tiled window, plot a workspace, then drag the plot onto the tiled window in Ubuntu 12.04.

[Roman Tolchenov]

Re #8909. Moved drop processing outside the event handler

Changeset: 1f49ab7687239c33d096adf51c9d329dd8d5bce2

[Samuel Jackson]

Couple of issues with this still (Ubuntu 12.04) :

• Reshaping and dragging a plot out of the window can cause a seg fault on occasions, (although I can't reproduce this reliably, but Roman has observed it too.)

• Adding some plots then deleting the workspace they came from clears the plots, but they still remain in the tiled window, and when you drag this out of the tiled window it causes a seg fault.

• If I drag a plot onto the separating lines between tiles, it makes the entire plot magically disappear.

• The ctrl+w command doesn't work for >1 tiled window.

[Roman Tolchenov]

A way to get the seg fault:

1. Open a tiled window and a couple of graphs.
2. Add the graphs to the tiled window.
3. Select one of the graphs (click on it - it will have a green border)
4. Reshape the window using main menu "Tiled Window->Reshape" option.
5. Try to interact with the window: crash.

[Roman Tolchenov]

Re #8909. Fix the crash and other issues.

Changeset: 52c93b86675a6c19783ba3177dd32b53e06b36d2

[Samuel Jackson]

All issues mentioned in comment 41 appear to have been resolved, including the seg fault. One further issue I've spotted is that mantid seems to be getting confused about the current active window. To reproduce:

• Load some data
• show the data, observe the 3D plot menu (for example) is now visible.
• close the data window. 3D plot menu is still there, and choosing an option from this list causes a crash!

This might be related to the new TiledWindow menu which is still showing up (with no options) even after I've deleted all the titled windows.

[Roman Tolchenov]

Re #8909. Fixed the menu issue.

Changeset: 1ce2f547761da5780ee57670d1e12e54c32e980e

[Roman Tolchenov]

Re #8909. Fix GCC warning

Changeset: 8c0cdfe655f19fa769a8c02e76e64c80d9f17101

[Samuel Jackson]

Merge remote-tracking branch 'origin/feature/8909_tiled_graph_displays'

Full changeset: ​b877533934cf506222cc651b33be8aa57b01efff

[Stuart Campbell]

This ticket has been transferred to github issue ​9752