Ticket #8942 (closed: fixed)
Link to local folder does not work in Script Repository window
Reported by: | Peter Parker | Owned by: | Harry Jeffery |
---|---|---|---|
Priority: | major | Milestone: | Release 3.3 |
Component: | GUI | Keywords: | |
Cc: | Blocked By: | ||
Blocking: | Tester: |
Description
To reproduce:
- Go to File → Script Repository.
- Install and pick a location if you haven't already.
- In the top-right-hand corner of the window there will be a blue hyper-link which should open a window showing you the folder.
Nothing will happen.
Change History
comment:2 Changed 7 years ago by Peter Parker
- Status changed from inprogress to verify
- Resolution set to fixed
Tester:
Seems likely this was only a problem on Windows, so testing in that environment would be a good idea.
- Reproduce the problem in Mantid 3.1 first.
- Then build branch and make sure the link works.
comment:4 Changed 7 years ago by Jay Rainey
- Status changed from verify to verifying
- Tester set to Jay Rainey
comment:5 Changed 7 years ago by Jay Rainey
- Status changed from verifying to reopened
- Resolution fixed deleted
The changes made address this issue (when the link is clicked, the folder opens), including appropriate error messages on windows. However, the opening folder functionality is no longer working on Linux (Ubuntu 12.04 64-bit) and an error is output, which is:
gvfs-open: file:file:///home/ck077685/MyScripts: error opening location: Operation not supported
I tested the functionality on master and I was able to open the folder when I clicked the link on Ubuntu, but not Windows (as expected).
comment:7 Changed 6 years ago by Nick Draper
- Owner changed from Peter Parker to Harry Jeffery
Could you look into this as peter will not be back until January
comment:9 Changed 6 years ago by Harry Jeffery
As Peter's original branch is so stale, I'm starting a new branch from master, cherry-picking Peter's commit and discarding the stale branch.
comment:10 Changed 6 years ago by Peter Parker
Refs #8942 - Fix link.
- Use QUrl::fromLocalFile to construct QUrl.
- Add error logging.
Changeset: a92d0ac440a7acb11c1855bff3c6a5bfcdf3ead3
comment:11 Changed 6 years ago by Harry Jeffery
comment:12 Changed 6 years ago by Harry Jeffery
- Status changed from inprogress to verify
- Resolution set to fixed
Testing
Note: The original branch has been discarded. You can review the changes here: https://github.com/mantidproject/mantid/compare/feature/8942_local_folder_link_not_working
I have resolved the issue on Linux, and it ought to still work on Windows, but I have only tested it on Linux. OSX should also work, as its file scheme is unix-y, but it still needs testing.
- Review code changes.
- Verify original problem can no longer be reproduced on Windows, Linux and OSX.
- Verify build is succeeding on all platforms.
- Verify no tests were (somehow) broken.
comment:13 Changed 6 years ago by Anders Markvardsen
- Status changed from verify to verifying
- Tester changed from Jay Rainey to Anders Markvardsen
comment:14 Changed 6 years ago by Anders Markvardsen
- Status changed from verifying to verify
- Tester Anders Markvardsen deleted
I have tested it on Windows and it works. Someone else please test on other platforms, in particular mac
comment:15 Changed 6 years ago by Martyn Gigg
- Status changed from verify to verifying
- Tester set to Martyn Gigg
comment:16 Changed 6 years ago by Martyn Gigg
- Status changed from verifying to verify
- Tester Martyn Gigg deleted
I can confirm this works on Ubuntu. Agreed that a Mac test is also necessary.
comment:18 Changed 6 years ago by Anders Markvardsen
- Status changed from verify to verifying
- Tester set to Anders Markvardsen
comment:19 Changed 6 years ago by Anders Markvardsen
- Status changed from verifying to verify
- Tester Anders Markvardsen deleted
Ups I have already tested it on window. Yes mac testing is remaining
comment:20 Changed 6 years ago by Owen Arnold
- Status changed from verify to closed
Merge remote-tracking branch 'origin/feature/8942_local_folder_link_not_working'
Full changeset: 15354999dcab24578700863233d6323b42ea0952
comment:21 Changed 6 years ago by Owen Arnold
Working on OSX
comment:22 Changed 6 years ago by Nick Draper
re #8942 resolve merge conflict to develop with a previous revert
Changeset: 5eaba94a352ca5d60408f5134f72a193ce98749f
comment:23 Changed 6 years ago by Nick Draper
re #8942 resolve merge conflict to develop with a previous revert
Changeset: 5eaba94a352ca5d60408f5134f72a193ce98749f
comment:24 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 9785
Refs #8942 - Fix link.
Changeset: 5e5090ff5a22e17d6cd673f2a0d7356c9c7f0b48