Ticket #9047 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

Create Example Flowchart for Workflow Algorithm wiki documents

Reported by: Karl Palmen Owned by: Karl Palmen
Priority: major Milestone: Release 3.2
Component: Documentation Keywords: mainternance
Cc: arturs.bekasovs@…, nick.draper@…, anders.markvardsen@… Blocked By:
Blocking: #8917 Tester: Nick Draper

Description

Select one workflow algorithm (or group of algorithms) and produce a flowchart for it/them using draw.io save both XML and image file. Link image from wiki page(s) and store the XML in a 'doc/diagrams' folder as sister of the 'include' and 'src' folders.

Change History

comment:1 Changed 7 years ago by Karl Palmen

draw.io can be accessed through https://www.draw.io/ .

comment:2 Changed 7 years ago by Karl Palmen

  • Component changed from Framework to Documentation

comment:3 Changed 7 years ago by Nick Draper

  • Status changed from new to assigned

comment:4 Changed 7 years ago by Karl Palmen

  • Status changed from assigned to inprogress

I've found a flowchart for muon workflow atached to ticket #8494. This could be made into an example for MuonLoad.

comment:5 Changed 7 years ago by Karl Palmen

Add XML version of flowchart for loadMuon re #9047

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: 02a7356a0cbee542edb89b1c4544df6f06c261ec

comment:6 Changed 7 years ago by Karl Palmen

Modify MuonLoad wiki to use flowchart re #9047

Also move XML for flowchart to WorkflowAlgorithms.

Changeset: 9d892df7bfa7bbfb7684356939dfe9b79b5c6534

comment:7 Changed 7 years ago by Karl Palmen

  • Status changed from inprogress to verify
  • Resolution set to fixed

To test check that the wiki for MuonLoad has been improved adequately with flow chart.

Look for MuonWorkflow.xml in WorkflowAlgorithms/doc/diagrams .

Go to https://www.draw.io and select "Device". Then select "Open existing diagram ..." and load the MuonWorkflow.xml file. You should then see a flowchart. Verify that it is a copy of the flowchart in the wiki.

comment:8 Changed 7 years ago by Karl Palmen

Also verify that the wiki was made by wikimaker.

comment:9 Changed 7 years ago by Karl Palmen

It is possible before testing that wikimaker has undone the changes. If so, find older version with the change in it.

comment:10 Changed 7 years ago by Karl Palmen

  • Status changed from verify to reopened
  • Resolution fixed deleted

comment:11 Changed 7 years ago by Karl Palmen

  • Cc arturs.bekasovs@… added

Workflow in flowchart is now out of date.

comment:12 Changed 7 years ago by Karl Palmen

  • Status changed from reopened to inprogress

comment:13 Changed 7 years ago by Karl Palmen

Update flowchart MuonWorkflow re #9047

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: d8d87595c3638595f60057138219acf49dc671a1

comment:14 Changed 7 years ago by Karl Palmen

  • Status changed from inprogress to verify
  • Resolution set to fixed

comment:15 Changed 7 years ago by Nick Draper

  • Status changed from verify to verifying
  • Tester set to Nick Draper

comment:16 Changed 7 years ago by Nick Draper

Spelling error in png file in the wiki http://www.mantidproject.org/images/a/a0/MuonWorkflow.png

Loaded Wprkspace -> Loaded Workspace

Also other items as discussed.

  1. use colour consistently
  2. Parameter names need to match those of the algorithm
  3. Drop the workspace icons in the diagram and just label the arrows
  4. Decisions need a label in the form of a question
  5. Only mention algorithms used within the workflow alg itself - do not go deeper within algs used within this alg (Example here is LoadNexusProcessed)
  6. Use the Cylinder (database) for the final output workspace
Last edited 7 years ago by Nick Draper (previous) (diff)

comment:17 Changed 7 years ago by Nick Draper

  • Status changed from verifying to reopened
  • Resolution fixed deleted

comment:18 Changed 7 years ago by Karl Palmen

  • Status changed from reopened to inprogress

Improve Flowchart and correct description of SecondPeriod re #9047

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: d31f57a07be9eeb0da703a86b6b9ba145e6ce136

comment:19 Changed 7 years ago by Karl Palmen

  • Status changed from inprogress to verify
  • Resolution set to fixed

comment:20 Changed 7 years ago by Karl Palmen

  • Status changed from verify to reopened
  • Resolution fixed deleted

comment:21 Changed 7 years ago by Karl Palmen

I'm looking into default handling.

comment:22 Changed 7 years ago by Karl Palmen

  • Status changed from reopened to inprogress

Modify the display of default handling in flowchart re #9047

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: 38e22f1aecf585efd38f3b9f3afc6f4220a8fd03

comment:23 Changed 7 years ago by Karl Palmen

  • Status changed from inprogress to verify
  • Resolution set to fixed

comment:24 Changed 7 years ago by Nick Draper

  • Status changed from verify to verifying

comment:25 Changed 7 years ago by Nick Draper

  • Status changed from verifying to closed

comment:26 Changed 7 years ago by Nick Draper

Merge remote-tracking branch 'origin/feature/9047_example_flowchart_wiki'

Full changeset: 7970a77d5770a78b651a0a330adcf915c7bc752e

comment:27 Changed 7 years ago by Nick Draper

  • Keywords SSC removed

comment:28 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 9890

Note: See TracTickets for help on using tickets.