Fix disallowed implicit casts to bool

[Peter Parker]

A ​recent Fedora 20 build highlighted a problem we've come across before, which is that Boost have changed the bool operator for their smart pointers to include the explicit keyword.

This manifested itself in the following error message:

08:46:23 /home/builder/jenkins/workspace/ornl_fedora20_master/Code/Mantid/MantidQt/CustomInterfaces/src/SANSRunWindow.cpp: In member function ‘void MantidQt::CustomInterfaces::SANSRunWindow::setGeometryDetails()’:
08:46:23 /home/builder/jenkins/workspace/ornl_fedora20_master/Code/Mantid/MantidQt/CustomInterfaces/src/SANSRunWindow.cpp:1443:78: error: cannot convert ‘boost::shared_ptr<const Mantid::API::WorkspaceGroup>’ to ‘const bool’ in initialization
08:46:23    const bool isGroupWs = boost::dynamic_pointer_cast<const WorkspaceGroup>(ws);
08:46:23                                                                               ^
08:46:23 /home/builder/jenkins/workspace/ornl_fedora20_master/Code/Mantid/MantidQt/CustomInterfaces/src/SANSRunWindow.cpp:1449:79: error: cannot convert ‘boost::shared_ptr<const Mantid::API::IEventWorkspace>’ to ‘const bool’ in initialization
08:46:23    const bool isEventWs = boost::dynamic_pointer_cast<const IEventWorkspace>(ws);

This occurred in work already merged into master, so I'm opening another ticket here to fix the bug.

[Owen Arnold]

Should be relatively easy to fix given the usage example.

[Peter Parker]

Refs #9085 - Fix errors for more recent versions of Boost.

Changeset: 4301d2dbd3430bad3ca6c7d069cf457e8fc8a08c

[Peter Parker]

Tester:

A code review and a check that the SNS Fedora 20 build now shows no sign of the errors above should be enough. If you really want to you can load one of the System Test SANS2D data files into the SANS ISIS interface and then check that the Geometry tab has been populated under the "Sample" heading.

[Peter Parker]

Somebody on Fedora 20 should test.

[Nick Draper]

Tested by code review as it is very simple.

[Nick Draper]

Merge remote-tracking branch 'origin/bugfix/9085_fix_disallowed_implicit_casts_to_bool'

Full changeset: ​f1aed905accdb74bcbe9eef3ef56c15aee37d6b0

[Stuart Campbell]

This ticket has been transferred to github issue ​9928