Ticket #961 (closed: fixed)

Opened 11 years ago

Last modified 5 years ago

Contrained and Tied Parameters

Reported by: Nick Draper Owned by: Anders Markvardsen
Priority: critical Milestone: Iteration 21
Component: Keywords:
Cc: Blocked By:
Blocking: Tester:

Description (last modified by Nick Draper) (diff)

Target Date: 02/12/2009

Constraints implemented using 'rake' penalty, tests implemented including do constraints help optimisation. Wiki page written including "rake" image link from fit page.

We need to be able to cope with tied Parameters 

a=1/(Z+3)
b=c/2
f=log(t)

and constrained parameters 

1<a<3

We discussed that constrained parameters may be added as a form of Function to add into the optimistaion, but Tied parameters cross different functions and therefore would need to be added at the solver level.

Change History

comment:1 Changed 11 years ago by Anders Markvardsen

(In [3419]) First implementation of constraint interface class and BoundaryConstraint. Refs #961.

comment:2 Changed 11 years ago by Anders Markvardsen

(In [3457]) Expanded IFunction interface to handle constraints. Refs #961.

comment:3 Changed 11 years ago by Anders Markvardsen

(In [3458]) Bring tests back to normal after previous commit to this ticket. Refs #961.

comment:4 Changed 11 years ago by Anders Markvardsen

(In [3461]) Linked IConstraint interface up with IFunction interface and Fit.h. Refs #961.

comment:5 Changed 11 years ago by Anders Markvardsen

(In [3462]) Comment constraint out from LorentzianTest for now. Refs #961.

comment:6 Changed 11 years ago by Anders Markvardsen

(In [3467]) First real IConstraint test where a constraint is put on the centre point of a Lorentzian away from the optimum value. Refs #961.

comment:7 Changed 11 years ago by Martyn Gigg

(In [3473]) Fix a crashing test. Also remove a couple of compiler and documentation warnings. Re #961

comment:8 Changed 11 years ago by Anders Markvardsen

(In [3511]) Modified function/composite function API to an agreeable handling of constraint. Refs #961.

comment:9 Changed 11 years ago by Anders Markvardsen

(In [3513]) Issue with composite function handling of constraint fixed (by roman). Lorentzian test extended. Refs #961.

comment:10 Changed 11 years ago by Nick Draper

  • Description modified (diff)

comment:11 Changed 11 years ago by Anders Markvardsen

(In [3522]) Changed the function constraint penalty from being adding a constant background to a spiky background. Problem with the constant background function penalty was that it correlated 100% with a real constant background parameter. Refs #961.

comment:12 Changed 11 years ago by Nick Draper

  • Description modified (diff)

comment:13 Changed 11 years ago by Anders Markvardsen

(In [3534]) IFunction method activeParameter() was not overwritten in Gaussian. Refs #961.

comment:14 Changed 11 years ago by Roman Tolchenov

(In [3535]) Added const in the declaration. re #961

comment:15 Changed 11 years ago by Roman Tolchenov

(In [3536]) Fixing FitTest. re #961

comment:16 Changed 11 years ago by Anders Markvardsen

(In [3540]) Add additional Gaussian constraint test and new wiki page FitConstraint. Refs #961.

comment:17 Changed 11 years ago by Anders Markvardsen

(In [3543]) In Fit.cpp force initial guess of parameters to satisfy constraints of function. Refs #961.

comment:18 Changed 11 years ago by Anders Markvardsen

  • Status changed from new to accepted

comment:19 Changed 11 years ago by Anders Markvardsen

  • Status changed from accepted to testing
  • Resolution set to fixed

comment:20 Changed 11 years ago by Martyn Gigg

  • Status changed from testing to closed

comment:21 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​1809

Note: See TracTickets for help on using tickets.