Ticket #10054 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

OneStepMDEWTest Too Slow

Reported by: Owen Arnold Owned by: Owen Arnold
Priority: major Milestone: Release 3.3
Component: Framework Keywords:
Cc: Blocked By:
Blocking: #9897 Tester: Harry Jeffery

Description (last modified by Owen Arnold) (diff)

Over 4 seconds to completion on RHEL6.

Change History

comment:1 Changed 6 years ago by Owen Arnold

  • Status changed from new to assigned
  • Description modified (diff)
  • Summary changed from Polarization Correction Test Too Slow (cloned) to OneStepMDEWTest Too Slow

comment:2 Changed 6 years ago by Owen Arnold

  • Status changed from assigned to inprogress

refs #10054. Fixes applied.

  • Use smaller event workspace as input
  • Deprecate algorithm as no longer needed
  • Replace single usage with two calls to nested algorithms

Changeset: c1c699607c56c6dfbebcaa38b5236bd9ec5e6bfb

comment:3 Changed 6 years ago by Owen Arnold

Tester: Look at the test speed. Now running in about a second, and it has to load data as part of the test, so it's fast enough. All unit tests should still be running OK.

comment:4 Changed 6 years ago by Martyn Gigg

It looks like the FrameworkManager::Instance() call in MDEvents::OneStepMDEW.cpp has caused the Windows debug tests to fail. I think the problem is that the when the FrameworkManager is created it loads the plugins (in the constructor), which in turn registers the algorithms. During registration an algorithm object is created, which in this case will call FrameworkManager::Instance() again but the first one has not finished being created yet so effectively 2 instances will have been created.

We shouldn't need that call in the constructor, if it is needed by a test then the test should call it.

comment:5 Changed 6 years ago by Owen Arnold

refs #10054. Remove frameworkmanager::instance.

Changeset: a6daad9b0b4f7d768a6afe5fa801518cae9844f4

comment:6 Changed 6 years ago by Owen Arnold

  • Status changed from inprogress to verify
  • Resolution set to fixed

comment:7 Changed 6 years ago by Harry Jeffery

  • Status changed from verify to verifying
  • Tester set to Harry Jeffery

comment:8 Changed 6 years ago by Harry Jeffery

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/feature/10054_one_step_mdew'

Full changeset: ​f398ab7b4f30c141a0471446bf5232c2cacf576a

comment:9 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​10896

Note: See TracTickets for help on using tickets.