Ticket #10074 (closed: fixed)
Merge Poldi system tests into systemtests/master
| Reported by: | Michael Wedel | Owned by: | Michael Wedel |
|---|---|---|---|
| Priority: | major | Milestone: | Release 3.3 |
| Component: | Diffraction | Keywords: | POLDI |
| Cc: | Blocked By: | ||
| Blocking: | Tester: | Martyn Gigg |
Description (last modified by Michael Wedel) (diff)
I noticed that some of the POLDI-related system tests were not merged into master when the respective tickets were closed.
This is a very small ticket, it just requires merging the following systemtest-branches into master:
- #9436 - feature/9436_poldi_merge_system_test
- #9445 - feature/9445_systemtest_for_poldi_2d_spectrum
- #9630 - feature/9630_poldi_truncate_data_test (this one is my bad, forgot to "git publish" it, but ran "git checkbuild" now.)
Is there a good way to prevent cases like the first two? I wrote in both tickets that there's a system test, but admittedly it's not visible too well. What about having an extra checkbox "Has systemtest" which leads to some kind of visual warning when the state is set to "fixed".
Change History
comment:3 Changed 6 years ago by Michael Wedel
Actually, the one in 9436 is also my mistake, since I did not run checkbuild on that one either - did that now.
comment:5 Changed 6 years ago by Michael Wedel
- Status changed from assigned to verify
- Resolution set to fixed
There is an new branch on systemtests, feature/10074_merge_poldi_system_tests, which contains all three branches mentioned above. Since these were already merged into develop and have been running for a while without failures, there is not really anything to test here.
comment:6 Changed 6 years ago by Martyn Gigg
- Status changed from verify to verifying
- Tester set to Martyn Gigg
comment:7 Changed 6 years ago by Martyn Gigg
- Status changed from verifying to closed
Merge branch 'feature/10074_merge_poldi_system_tests'
Full changeset: 0cd845e4a5a49d744d2fca17bc6bfc78ab37677e
comment:8 Changed 6 years ago by Martyn Gigg
It would be nice to have better checks. I think anything on the ticket is likely to still fall foul of testers not reading the ticket instructions properly.
I think the "real" fix to this situation is our long-term plan to merge to two repositories back together (without the data). This would automatically resolve the situation. It's a long way off though as we have to figure out how to share the data.
