Ticket #10162 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

TofConverter gui is broken.

Reported by: Harry Jeffery Owned by: Harry Jeffery
Priority: critical Milestone: Release 3.3
Component: GUI Keywords:
Cc: Blocked By:
Blocking: Tester: Michael Reuter

Description

Open Interfaces->Utility->TofConverter 

File "/home/harry/MantidProject/main/repo/Code/Mantid/scripts/TofConverter/converterGUI.py", line 70
    else:
                               ^
SyntaxError: invalid syntax
  at line 1 in '<Interface>'

Change History

comment:1 Changed 6 years ago by Harry Jeffery

Fix broken TofConverter gui.

Refs #10162.

Changeset: 7684e001e8da1ea6f886db2c4cd58ff81108bec6

comment:2 Changed 6 years ago by Harry Jeffery

  • Status changed from new to assigned

comment:3 Changed 6 years ago by Harry Jeffery

  • Status changed from assigned to verify
  • Resolution set to fixed

comment:4 Changed 6 years ago by Harry Jeffery

  • Status changed from verify to reopened
  • Resolution fixed deleted

Let's fix the tabs while we're at it.

comment:5 Changed 6 years ago by Harry Jeffery

  • Status changed from reopened to inprogress

Fix tabs and other issues in convertGUI.py

Other issues fixed:

  • pi was hardcoded and never used
  • e2cm had been mistyped
  • blank line usage was inconsistent

Refs #10162.

Changeset: 6f3c4a65aeea1a658a8ce196451d33e3583b9ab0

comment:6 Changed 6 years ago by Harry Jeffery

Fix error when converting to momentum transfer.

The gui would complain that theta needs to be > 0 when a value had been entered correctly.

Refs #10162.

Changeset: 9ffc16c84c46741e19518ed7e500940aabfea6bd

comment:7 Changed 6 years ago by Harry Jeffery

  • Status changed from inprogress to verify
  • Resolution set to fixed

TofConverter should be much happier now.

Testing

  • Open Interfaces->Utility->TofConverter
  • Play about with the unit conversions
    • Verify conversion to momentum transfer works for values of theta (scattering angle) > 0.
  • Code inspection
    • Use git diff -w to see all non-whitespace changes.

comment:8 Changed 6 years ago by Michael Reuter

  • Status changed from verify to verifying
  • Tester set to Michael Reuter

comment:9 Changed 6 years ago by Michael Reuter

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/bugfix/10162_tofconverter_gui_is_broken'

Full changeset: ​06e1a705eb31ccca5a9dd891a1baf8f255bd952d

comment:10 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​11004

Note: See TracTickets for help on using tickets.