Ticket #10190 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

PDFgui file writer

Reported by: Peter Peterson Owned by: Peter Peterson
Priority: major Milestone: Release 3.3
Component: Diffraction Keywords:
Cc: Blocked By:
Blocking: #10423 Tester: Ross Whitfield

Description

PDFgui takes data in the format of (x,y,dx,dy). Add an algorithm to write this out.

Change History

comment:1 Changed 6 years ago by Nick Draper

  • Status changed from new to assigned

comment:2 Changed 6 years ago by Pete Peterson

  • Status changed from assigned to inprogress

Re #10190. Adding generated algorithm code.

Changeset: fd64ec84a436e7b2fc4674322219e7c38e530d0b

comment:3 Changed 6 years ago by Pete Peterson

Re #10190. Code compiles.

Changeset: a80245c02be3fdd44ea354df6f9c9345b3e0def8

comment:4 Changed 6 years ago by Pete Peterson

Refs #10190. First pass or writing out the data values.

Changeset: 24b1b9cae6c663e5e45209c726e37e00fa665ad4

comment:5 Changed 6 years ago by Pete Peterson

Refs #10190. Forgot leading whitespace.

Changeset: 6c31ae98255a66e34b5079170b6eaf48d59dbb75

comment:6 Changed 6 years ago by Pete Peterson

Refs #10190. Added mantid version to the output.

Changeset: 9591ddfb0d18902d0cd277c89ab6e146fbe5544d

comment:7 Changed 6 years ago by Pete Peterson

Refs #10190. Adding meaningful unit test.

Changeset: ae43f3d93ddf932e20f716f00a065f84f990038e

comment:8 Changed 6 years ago by Peter Peterson

  • Blocking 10423 added

comment:9 Changed 6 years ago by Pete Peterson

  • Status changed from inprogress to verify
  • Resolution set to fixed

This is being verified as ​pull request #50.

comment:10 Changed 6 years ago by Pete Peterson

Refs #10190. Fixing osx build.

Changeset: ebd4ed50dff762c84ff4328c5c07c4758175d79d

comment:11 Changed 6 years ago by Raquel Alvarez Banos

  • Status changed from verify to verifying
  • Tester set to Raquel Alvarez Banos

comment:12 Changed 6 years ago by Pete Peterson

test this please

comment:13 Changed 6 years ago by Raquel Alvarez Banos

  • Status changed from verifying to reopened
  • Resolution fixed deleted

Hi Peter,

I reopened this ticket, as when following the steps below the code crashes throwing an "Expression: vector subscript out of range" error.

This is what I tried:

comment:14 Changed 6 years ago by Pete Peterson

The trac ticket reviewer bounced this one.

comment:15 Changed 6 years ago by Peter Peterson

...and the rst needs to be worked on.

comment:16 Changed 6 years ago by Pete Peterson

  • Status changed from reopened to inprogress

Refs #10190. Hopefully fixing the usage example.

Changeset: 145174fe38c73199e4ba89cf0d0439f1aa6e968f

comment:17 Changed 6 years ago by Martyn Gigg

retest this please

comment:18 Changed 6 years ago by Raquel Alvarez Banos

Hi, just retested the ticket and got the following error, it seems that the branch was not fully merged in develop:

ERROR: Branch 'feature/10190_pdfgui_files' has not been fully merged to develop, meaning it is not possible to know whether the code is valid on all environments.

Contact Pete Peterson on petersonpf@… (or via skype) and ask them to merge the code to develop using 'git checkbuild' from their branch feature/10190_pdfgui_files and let you know when it passes testing on the buildservers so you can start testing.

comment:19 Changed 6 years ago by Peter Peterson

I skipped that, but the ​pull request #50 has the build results.

comment:20 Changed 6 years ago by Peter Peterson

  • Status changed from inprogress to verify
  • Resolution set to fixed

I cannot reproduce the error mentioned in comment:13.

comment:21 Changed 6 years ago by Ross Whitfield

  • Status changed from verify to verifying
  • Tester changed from Raquel Alvarez Banos to Ross Whitfield

comment:22 Changed 6 years ago by Pete Peterson

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/master' into feature/10190_pdfgui_files

Full changeset: ​f4233f34b4ac979e6ef838dea972bcaff82bd5fe

comment:23 Changed 6 years ago by Ross Whitfield

Merge pull request #50 from mantidproject/feature/10190_pdfgui_files

PDFgui file writer

Full changeset: ​68ef30fd5f2e1256451bb34f0c317b4b62147a63

comment:24 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​11032

Note: See TracTickets for help on using tickets.