Ticket #10322 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

Mantid does not start if there is an inaccessible dir in the save or search paths

Reported by: Martyn Gigg Owned by: Nick Draper
Priority: critical Milestone: Release 3.3
Component: Framework Keywords:
Cc: Blocked By:
Blocking: #10484 Tester: Federico M Pouzols

Description

Observed on Windows 7 where an inaccessible network drive was set as the defaultsave.directory. Mantid takes a long time to start and then throws up an Python initialization error saying there has been a file access problem.

Change History

comment:1 Changed 6 years ago by Nick Draper

  • Owner set to Nick Draper
  • Status changed from new to assigned

comment:2 Changed 6 years ago by Nick Draper

  • Status changed from assigned to inprogress

re #10322 Added error handling around a directory checking routine

Changeset: da8423bf22cc99bfd7e3a194cfc19ceea310dea0

comment:3 Changed 6 years ago by Nick Draper

  • Status changed from inprogress to verify
  • Resolution set to fixed

Instructions to test are aimed at Windows (you might be able to do something similar on linux)

To Test

  1. Share a folder on your computer as z:
  2. Map a drive to that share
  3. Go back to the folder, select properties, sharing, advanced sharing and untick the box that says share this folder.
  4. You now have an invalid network drive
  5. Open Mantid.user.properties and set DefaultSave.Directory = Z:/
  6. Open Mantidplot, it should open successfully, and python should still work
  7. Undo the mess you have made!

comment:4 Changed 6 years ago by Nick Draper

re #10322 Added the exception include, strange win didn't need this

Changeset: 56a69933773fcf6590d7a3bab0c1ca7cfa33ad12

comment:5 Changed 6 years ago by Martyn Gigg

  • Blocking 10484 added

(In #10484) Federico is correct. This been based on #10322 by accident.

I have added #10322 as a blocker so that it has to be merged first to avoid any issues.

comment:6 Changed 6 years ago by Federico M Pouzols

  • Status changed from verify to verifying
  • Tester set to Federico M Pouzols

comment:7 Changed 6 years ago by Federico M Pouzols

  • Status changed from verifying to closed

I did the suggested mess test (Windows 7) and it works. It handles the mess gracefully, the broken path/drive is ignored.

The new code looks clear and does the job.

comment:8 Changed 6 years ago by FedeMPouzols

Merge remote-tracking branch 'origin/feature/10322_Mantid_will_not_start_with_bad_path'

Full changeset: ​92355232fca526480e698b2f6f4a231e57cf9570

comment:9 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​11164

Note: See TracTickets for help on using tickets.