Ticket #10333 (closed: fixed)
Mac: problem loading NXSPE file
| Reported by: | Nick Draper | Owned by: | Owen Arnold |
|---|---|---|---|
| Priority: | major | Milestone: | Release 3.3 |
| Component: | Direct Inelastic | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | #9995 | Tester: | Stuart Campbell |
Description
This works fine on windows, fails on Mac ?linux
Using version 3.2.1 I get the following error when trying to load an nxspe file
LoadNXSPE started Error in execution of algorithm LoadNXSPE: Not NeXus or notNXSPE
It loads fine on my PC version of mantid.
The file in question is:
olympic\babylon5\public\ross\MAP05935_4to1_033.nxspe
Cheers Ross
Change History
comment:3 Changed 6 years ago by Owen Arnold
- Status changed from assigned to verify
- Resolution set to fixed
comment:4 Changed 6 years ago by Owen Arnold
- Status changed from verify to reopened
- Resolution fixed deleted
comment:5 Changed 6 years ago by Owen Arnold
- Status changed from reopened to inprogress
refs #10333. Work around NeXus bug.
Fixed and enabled tests that Russell previously disabled.
Extracted confidence functionality and exposed as a static public class member.
Give good, but not excellent confidence for restricted partial string matches with NXSPE.
Added extra tests for the confidence funtionality.
Changeset: 6fd48173055d72f77627ff3f9cfa1a7f54dd8df6
comment:6 Changed 6 years ago by Owen Arnold
refs #10333. Fix merge conflicts on develop.
Merge branch 'feature/10333_osx_nxspe' into develop
Changeset: 8bfa3f30ebccf16f0a7e6ddd698eb08dd66e2d0a
comment:7 Changed 6 years ago by Owen Arnold
refs #10333. Fix merge conflict.
Changeset: 8318fe4df9b8b0c50355705f3f42adb5555a3f78
comment:8 Changed 6 years ago by Owen Arnold
This is not an issue on our side. I've created a bug about this for the NeXus group. If there is a requirement to update our NeXus libraries following a fix. I will do that when it's available.
Loading and resaving the file in Mantid seems to have solved the issue for this particular file, so I've updated the file on olympic/Babylon5/Public/abuts/VATES_Training/Example1/MAP05935_4to1_033.nxspe
I've added a softer confidence level in LoadNXSPE. This is unit tested, but you can also test this by trying to load the NXSPE files in Example3 of the above VATES training directory.
comment:9 Changed 6 years ago by Owen Arnold
- Status changed from inprogress to verify
- Resolution set to fixed
comment:10 Changed 6 years ago by Stuart Campbell
- Status changed from verify to verifying
- Tester set to Stuart Campbell
comment:11 Changed 6 years ago by Stuart Campbell
Changes look ok - but it won't cleanly merge with master
comment:12 Changed 6 years ago by Owen Arnold
refs #10333. Merge in master and fix conflicts.
Merge branch 'master' into feature/10333_osx_nxspe
Conflicts:
Code/Mantid/Framework/DataHandling/src/LoadNXSPE.cpp
Changeset: 8fa6a7d7ea296c6841423630f0ad675dbd3d758b
comment:13 Changed 6 years ago by Owen Arnold
- Status changed from verifying to verify
This is being verified as pull request #48.
comment:15 Changed 6 years ago by Stuart Campbell
- Status changed from verifying to closed
Merge pull request #48 from mantidproject/feature/10333_osx_nxspe
Feature/10333 osx nxspe
Full changeset: b0464d6976867f2c10e7bccae08a947507c716c5
comment:17 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 11175
There's a problem here: https://github.com/mantidproject/mantid/blob/master/Code/Mantid/Framework/DataHandling/src/LoadNXSPE.cpp#L67 with getStrData. on OSX, you only get the first 4 characters of the 5 character string.