Ticket #10355 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

Add SANS fit functions

Reported by: Mathieu Doucet Owned by: Mathieu Doucet
Priority: major Milestone: Release 3.3
Component: SANS Keywords:
Cc: Blocked By:
Blocking: Tester: Andrei Savici

Description

Add the following fit functions for SANS:

  • Guinier, Porod, Lorentz and Guinier-Porod

Change History

comment:1 Changed 6 years ago by Mathieu Doucet

  • Status changed from new to assigned

comment:2 Changed 6 years ago by Mathieu Doucet

  • Status changed from assigned to inprogress

Re #10355 added four models

Changeset: eb87f8875767b0d93fa71592486fd219933831bf

comment:3 Changed 6 years ago by Mathieu Doucet

  • Status changed from inprogress to verify
  • Resolution set to fixed

comment:4 Changed 6 years ago by Mathieu Doucet

To test:

  • Load you favorite reduced SANS data (or any other data)
  • Fit using the fit panel in Mantid, and try out each of the new functions

comment:5 Changed 6 years ago by Mathieu Doucet

  • Component changed from Framework to SANS

comment:6 Changed 6 years ago by Mathieu Doucet

  • Status changed from verify to reopened
  • Resolution fixed deleted

comment:7 Changed 6 years ago by Mathieu Doucet

  • Status changed from reopened to inprogress

Re #10355 check boundary constraints

Changeset: b3b7b98529cee29a5293381ac68d13ef46ed9b6c

comment:8 Changed 6 years ago by Mathieu Doucet

  • Status changed from inprogress to verify
  • Resolution set to fixed

comment:9 Changed 6 years ago by Raquel Alvarez Banos

  • Status changed from verify to verifying
  • Tester set to Raquel Alvarez Banos

comment:10 Changed 6 years ago by Raquel Alvarez Banos

  • Status changed from verifying to reopened
  • Resolution fixed deleted

Hi Mathieu, I reopened this ticket due to the message below, it seems it has not been fully merged in develop:

ERROR: Branch 'feature/10355_basic_sans_models' has not been fully merged to develop, meaning it is not possible to know whether the code is valid on all environments.

Contact Mathieu Doucet on doucetm@… (or via skype) and ask them to merge the code to develop using 'git checkbuild' from their branch feature/10355_basic_sans_models and let you know when it passes testing on the buildservers so you can start testing.

comment:11 Changed 6 years ago by Mathieu Doucet

  • Status changed from reopened to verify
  • Resolution set to fixed

comment:12 Changed 6 years ago by Andrei Savici

  • Status changed from verify to verifying
  • Tester changed from Raquel Alvarez Banos to Andrei Savici

comment:13 Changed 6 years ago by Mathieu Doucet

Re #10355 Add documentation

Changeset: 12689f3a9bd1ec0c77c79d31104a3185ceae1626

comment:14 Changed 6 years ago by Mathieu Doucet

Re #10355 Tweak docs

Changeset: 5166a3cfafb5c0657182870b305938d8d381aa47

comment:15 Changed 6 years ago by Andrei Savici

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/feature/10355_basic_sans_models'

Full changeset: ​e01cd0c1dc721d882bac3fcb9802d6c6d4ded006

comment:16 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​11197

Note: See TracTickets for help on using tickets.