Ticket #10377 (closed: fixed)
Sample material UI
| Reported by: | Dan Nixon | Owned by: | Dan Nixon |
|---|---|---|---|
| Priority: | major | Milestone: | Release 3.3 |
| Component: | Framework | Keywords: | CORE |
| Cc: | spencer.howells@… | Blocked By: | |
| Blocking: | Tester: | Roman Tolchenov |
Description
Spencer has suggested a adding a UI similar to the Sample Logs UI (accessed from the context menu of a workspace) for the sample material, as currently (as far as I can see at least) there is no simple way to do this in MantidPlot.
It could also incorporate the CopySample and SetSampleMaterial algorithms, or at least have buttons to create them with the workspaces pre-selected.
Change History
comment:2 Changed 6 years ago by Dan Nixon
- Status changed from assigned to inprogress
Added skeleton window for smaple metrial dialog
Refs #10377
Changeset: fe68c71e1bf58699264bbd2fadeb65b6966fb864
comment:4 Changed 6 years ago by Dan Nixon
Better tree layout and algorithm buttons
Refs #10377
Changeset: f6f9698e9235663eaf00241627c0cca375af59c2
comment:8 Changed 6 years ago by Dan Nixon
Do not allow duplicate observers on an algorithm
Add unit test for this
Refs #10377
Changeset: f6b01f277480cc07bff5ac71d500e7273588c53d
comment:10 Changed 6 years ago by Dan Nixon
- Keywords CORE added
- Status changed from inprogress to verify
- Resolution set to fixed
(the changes to Algorithm and AlgorithmProxy probably justify the CORE keyword)
comment:11 Changed 6 years ago by Roman Tolchenov
- Status changed from verify to verifying
- Tester set to Roman Tolchenov
comment:12 Changed 6 years ago by Roman Tolchenov
- Status changed from verifying to reopened
- Resolution fixed deleted
Changes to Algorithm should be done in a separate ticket. I don't think there is an issue with observers and AlgorithmProxy if they are set after all properties right before calling execute().
comment:13 Changed 6 years ago by Dan Nixon
I accept that the algorithm changes are better done in a septate ticket and will open one for it.
That is the issue I have with AlgorithmProxy, when it is used from an algorithm dialog there is no way to add observers after adding properties without significant modifications to algorithm dialog.
comment:14 Changed 6 years ago by Roman Tolchenov
The problem can possibly be solved by changing the order of setting observers and properties in void MantidUI::showAlgorithmDialog(...).
Another solution would be to make MantidUI (optionally) create concrete algorithms directly.
comment:15 Changed 6 years ago by Dan Nixon
- Status changed from reopened to inprogress
Revert "Use std::find to search observers"
This reverts commit c17b1dd1017433c17c6181f57d82235f49c2b239.
Refs #10377
Changeset: 5b96dcbaee2acf7fd07d25e756aa3f4360648e8e
comment:16 Changed 6 years ago by Dan Nixon
Revert "Do not allow duplicate observers on an algorithm"
This reverts commit f6b01f277480cc07bff5ac71d500e7273588c53d.
Refs #10377
Changeset: 3b77c10eca933c5a91ce3674784ce174da353f24
comment:17 Changed 6 years ago by Dan Nixon
Do not clear the observer list
Refs #10377
Changeset: e253d3dcb1d0be558e54e96fb7b3a604b91eb914
(the commit message here really should have said "Clear the observer list")
comment:18 Changed 6 years ago by Dan Nixon
Modify AlgorithmDialog to add observers just before execution
Refs #10377
Changeset: ab5d65d0239754d693f8767e24e71cb25fb9e31e
comment:19 Changed 6 years ago by Dan Nixon
comment:20 Changed 6 years ago by Dan Nixon
- Status changed from inprogress to verify
- Resolution set to fixed
comment:21 Changed 6 years ago by Pete Peterson
- Status changed from verify to closed
Merge remote-tracking branch 'origin/feature/10377_sample_material_ui'
Full changeset: 7705d27f5b0b5335e70e1df6356401634bbf787d
comment:22 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 11219
