Ticket #10432 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

POLDI specific analysis of residuals

Reported by: Michael Wedel Owned by: Michael Wedel
Priority: major Milestone: Release 3.3
Component: Diffraction Keywords: POLDI
Cc: Blocked By:
Blocking: Tester: Nick Draper

Description

After fitting a model to POLDI data (2D) there are usually some residuals. These are evaluated using a procedure which is based on the correlation analysis performed on POLDI raw data. This method reveals for example additional reflections that were not used in the fitting model.

Since it's vital for the POLDI data analysis, I have to add an algorithm that performs the analysis of residuals.

Change History

comment:1 Changed 6 years ago by Nick Draper

  • Status changed from new to assigned

comment:2 Changed 6 years ago by Michael Wedel

  • Status changed from assigned to inprogress

Refs #10432. Cleaning up PoldiAutoCorrelationCore, adding norm counts

Changeset: cd05ffc8d6883d39bb20e5e3d0c15570a772a096

comment:3 Changed 6 years ago by Michael Wedel

Refs #10432. Added algorithm

Changeset: 9877170eec8f3a16e0f00956616aafa22d609f71

comment:4 Changed 6 years ago by Michael Wedel

Refs #10432. Adding latest parameters for comparison.

Current software works with those parameters, so for comparison they are required.

Changeset: 39ff6ac19b5821f8dd7a200f9495a3d31977a980

comment:5 Changed 6 years ago by Michael Wedel

Refs #10432. First steps of algorithm.

Changeset: 3c9556f657ad003c62b97416fb62f5a5e0c95c93

comment:6 Changed 6 years ago by Michael Wedel

Refs #10432. Small changes to PoldiCalculateSpectrum2D

Changeset: 8112591b9bd87638513d306d967f62384de60709

comment:7 Changed 6 years ago by Michael Wedel

Refs #10432. Removing magic number from CostFuncLeastSquares

Changeset: e41045891877341621472360650ff412e8103f52

comment:8 Changed 6 years ago by Michael Wedel

Refs #10432. Some more refactoring in PoldiAutoCorrelationCore

This is needed as preparation for implementing the residual calculation, because some of the steps are actually different.

Changeset: c7e2723692c3fe02d464ad215770b83fdd696419

comment:9 Changed 6 years ago by Michael Wedel

Refs #10432. Added PoldiResidualCorrelatonCore.

Algorithm is working correctly.

Changeset: 9a714cdd026c14db87afdcf7645345256cb29c44

comment:10 Changed 6 years ago by Michael Wedel

Refs #10432. Refactored PoldiResidualCorrelationCore, added tests

Changeset: 1dbc7bdf96d58b11aafd7760c2a0db30ded27a4b

comment:11 Changed 6 years ago by Michael Wedel

Refs #10432. Using straight-forward detector index

Changeset: 555c1ba8e2f4e08135f4450ee890d35cdb58c4db

comment:12 Changed 6 years ago by Michael Wedel

Refs #10432. Adding tests to PoldiAnalyseResiduals

Changeset: c467f9de9b0d92eec2ac0ce52f32be48271463e0

comment:13 Changed 6 years ago by Michael Wedel

Refs #10432. Completing PoldiAnalyseResiduals, added tests

Changeset: d30afca6ceaa7dfc9f36c90b177f97c4c2f40310

comment:14 Changed 6 years ago by Michael Wedel

Revert "Refs #10432. Removing magic number from CostFuncLeastSquares"

This reverts commit e41045891877341621472360650ff412e8103f52.

Changeset: e5a2f89444797b1fb0c5bdc20699ef8c592f51f2

comment:15 Changed 6 years ago by Michael Wedel

Revert "Refs #10432. Small changes to PoldiCalculateSpectrum2D"

This reverts commit 8112591b9bd87638513d306d967f62384de60709.

Changeset: ee28d0dbce4a51585c54189ca6bd0482cfdf0913

comment:16 Changed 6 years ago by Michael Wedel

Refs #10432. Had to change reference files for correlation test

Parameters were changed, so in order to get the system test for PoldiAnalyseResiduals working, these files had to be re-calculated using the new parameters.

Changeset: 12ab3832a85f88606ae927b7d7bc3910ae1496e5

comment:17 Changed 6 years ago by Michael Wedel

Refs #10432. Adding reference data for new system test.

Changeset: 1e792f620deb996e9b6ef6868350fe44ef97bd99

comment:18 Changed 6 years ago by Michael Wedel

Refs #10432. Had to update POLDI parameters for system tests.

Changeset: 7b873c3d6c2b91b7d55e6fb64a7a500d4acd54a5

comment:19 Changed 6 years ago by Michael Wedel

Refs #10432. Added system test for PoldiAnalyseResiduals

Changeset: 7e3f1c34b47d311512f440fe35e121d728f5148a

comment:20 Changed 6 years ago by Michael Wedel

Refs #10432. Added documentation page

Changeset: a83a6baffa328488168dea7751016f895dcc7960

comment:21 Changed 6 years ago by Michael Wedel

Testing information

Make sure that all tests and all system tests are passing. A new system test has been added, which checks that the algorithm performs the analysis correctly.

The documentation does not have a usage example yet, because on current master Poldi data can not be fitted. While implementing this algorithm I discovered that enabling fitting is relatively easy and does not require a lot of code - I will put it into a separate ticket. The usage example for this algorithm will be added in that ticket.

comment:22 Changed 6 years ago by Michael Wedel

Refs #10432. Adding includes for std::transform and accumulate

Changeset: c7aa639c7fcef7197f6548ae8fe23e54159a0e14

comment:23 Changed 6 years ago by Michael Wedel

Refs #10432. Added another include.

Changeset: 6e7afd6652541f4df70a0ad63974b34181f94b6a

comment:24 Changed 6 years ago by Michael Wedel

Refs #10432. Fix typo in rst file

Changeset: 24a6d41781b4d1c8f8017e4d70f14de5eedca616

comment:25 Changed 6 years ago by Michael Wedel

  • Status changed from inprogress to verify
  • Resolution set to fixed

comment:26 Changed 6 years ago by Nick Draper

  • Status changed from verify to verifying
  • Tester set to Nick Draper

comment:27 Changed 6 years ago by Nick Draper

unit and system tests have been passing since last commit.

comment:28 Changed 6 years ago by Nick Draper

  • Status changed from verifying to closed

POLDIAnalyseResidualsTest passed

Merge and compilation passed

comment:29 Changed 6 years ago by Nick Draper

Merge remote-tracking branch 'origin/feature/10432_POLDI_residual_analysis'

Full changeset: 603ecbc123f6cb90e490a70d2cb6228d39d199a8

comment:30 Changed 6 years ago by Martyn Gigg

Merge branch 'feature/10432_POLDI_residual_analysis'

Full changeset: cf2a0ffe14bafb150b00a2b5a3925dff3ca3ad46

comment:31 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 11274

Note: See TracTickets for help on using tickets.