Ticket #10439 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

FindPyQt.py relying on deprecated pyqtconfig

Reported by: Ross Whitfield Owned by: Ross Whitfield
Priority: minor Milestone: Release 3.4
Component: Framework Keywords:
Cc: Blocked By:
Blocking: Tester:

Description

PyQt4.pyqtconfig has been deprecated since version 4.10 and is no longer included in modern OSes.

FindPyQt.py should optionally use PyQt4.QtCore.PYQT_CONFIGURATION in order to determine version and pyqt_sip_flags.

Change History

comment:1 Changed 6 years ago by Ross Whitfield

  • Status changed from new to assigned

comment:2 Changed 6 years ago by Ross Whitfield

  • Status changed from assigned to inprogress

Refs #10439 Update FindPyQt.py and FindPyQt4.cmake from kdelibs.

Source ​https://projects.kde.org/projects/kde/kdelibs/repository/revisions/a7e47438d4e3469dc9df70d613826cb360fc8d19

Changeset: d62913cde043a7523b7f4579861ba3e0f3174f9c

comment:3 Changed 6 years ago by Ross Whitfield

  • Status changed from inprogress to verify
  • Resolution set to fixed

This is being verified as ​pull request #55.

comment:4 Changed 6 years ago by Stuart Campbell

Merge pull request #55 from mantidproject/feature/10439_findpyqt_cmake_update

Refs #10439 Update FindPyQt.py and FindPyQt4.cmake from kdelibs.

Changeset: d355f0f91cbb84a570be3bd7a3c1d23f6e4bb6ae

comment:5 Changed 6 years ago by Stuart Campbell

  • Status changed from verify to closed

Merge pull request #55 from mantidproject/feature/10439_findpyqt_cmake_update

Refs #10439 Update FindPyQt.py and FindPyQt4.cmake from kdelibs.

Full changeset: ​d355f0f91cbb84a570be3bd7a3c1d23f6e4bb6ae

comment:6 Changed 6 years ago by Nick Draper

  • Milestone changed from Backlog to Release 3.4

moved to r 3.4 as tickets are closed

comment:7 Changed 5 years ago by Nick Draper

Somehow these slipped through without a resolution. Set to Fixed.

comment:8 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​11281

Note: See TracTickets for help on using tickets.