Ticket #10450 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

ExportExperimentLog should sort by run number

Reported by: Peter Peterson Owned by: Wenduo Zhou
Priority: major Milestone: Release 3.3
Component: Framework Keywords:
Cc: Blocked By:
Blocking: #10327 Tester: Martyn Gigg

Description

The file should be sorted by run number when it is written out.

This is being requested by Ke An.

Attachments

IPTS-11415-AutoRecord.txt​ (60.3 KB) - added by Wenduo Zhou 6 years ago.

Change History

comment:1 Changed 6 years ago by Wenduo Zhou

  • Status changed from new to assigned
  • Milestone changed from Backlog to Release 3.3

comment:2 Changed 6 years ago by Wenduo Zhou

  • Status changed from assigned to inprogress

Refs #10450. Enable unit test to test numerical operation.

On the TimeSeriesProperty such as min, max, avarage and etc.

On branch feature/10450_record_order_by_runnumber

modified: ../Mantid/Framework/PythonInterface/test/python/plugins/algorithms/ExportExperimentLogTest.py

Changeset: 6fd6b26f7144c26bf6eefe314853513ae9afb169

comment:3 Changed 6 years ago by Wenduo Zhou

Refs #10450. Added sorting functionality to algorithm.

And enable the algirthm to remove bad character ('\x0') automatically. Unit test is added for the new features

On branch feature/10450_record_order_by_runnumber

modified: ../Mantid/Framework/PythonInterface/plugins/algorithms/ExportExperimentLog.py

modified: ../Mantid/Framework/PythonInterface/test/python/plugins/algorithms/ExportExperimentLogTest.py

Changeset: e8de6692dc7f8b3ef5646b646591505e1b36dca0

comment:4 Changed 6 years ago by Wenduo Zhou

Refs #10450. Added a new property to algorithm.

to override the log value from workspace. and a new unit test is added for the new feature.

On branch feature/10450_record_order_by_runnumber

modified: ../Mantid/Framework/PythonInterface/plugins/algorithms/ExportExperimentLog.py modified: ../Mantid/Framework/PythonInterface/test/python/plugins/algorithms/ExportExperimentLogTest.py

Changeset: aaa91ef7b1c98bd435783e6997ce5345fa0324d6

comment:5 Changed 6 years ago by Wenduo Zhou

Refs #10450. Consider the case of duplicated records.

Changeset: 686c162db2dab83ee1b9856431fb25166d4b0546

comment:6 Changed 6 years ago by Wenduo Zhou

Refs #10450. Added an optional feature to remove records.

Optional feature to have remove records with duplicated value in sample log that is to be ordered by.

Changeset: 995991d65b720597c155bec035956b69b334d84b

comment:7 Changed 6 years ago by Wenduo Zhou

  • Status changed from inprogress to verify
  • Resolution set to fixed

For tester

  1. Please check the unit tests for the new features added to ExportExperimentLog;
  2. It was applied to Vulcan's auto reduction via mantid unstable. It is well tested there;
  3. You can do a quick check. Generate the experiment log file on several original Nexus files. Do it in a random order. If you set OrderBy to RUN, then you will see the final experiment log file is in order of RUN. Attached is a example experiment log file from VULCAN.

Changed 6 years ago by Wenduo Zhou

comment:8 Changed 6 years ago by Wenduo Zhou

  • Blocking 10327 added

comment:9 Changed 6 years ago by Peter Peterson

  • Status changed from verify to verifying
  • Tester set to Peter Peterson

comment:10 Changed 6 years ago by Peter Peterson

  • Status changed from verifying to reopened
  • Resolution fixed deleted

There is too much information going into the information log level with the prefix DB. Remove the prefix and put it in the debug log level.

comment:11 Changed 6 years ago by Wenduo Zhou

  • Status changed from reopened to inprogress

Refs #10450. Cleaned up the log output.

Changeset: ae7ede06e9e5dfe58342e0b8aab4d9de2b92c671

comment:12 Changed 6 years ago by Wenduo Zhou

  • Status changed from inprogress to verify
  • Resolution set to fixed

comment:13 Changed 6 years ago by Martyn Gigg

  • Status changed from verify to verifying
  • Tester changed from Peter Peterson to Martyn Gigg

comment:14 Changed 6 years ago by Martyn Gigg

Logging has been cleaned up and most moved to debug.

comment:15 Changed 6 years ago by Martyn Gigg

  • Status changed from verifying to closed

Merge branch 'feature/10450_record_order_by_runnumber'

Full changeset: ​391f852b26c2134c02b7a4a4b862d977f5c476e0

comment:16 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​11292

Note: See TracTickets for help on using tickets.