Ticket #10472 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

Fix some recent coverity warnings

Reported by: Martyn Gigg Owned by: Martyn Gigg
Priority: major Milestone: Release 3.3
Component: Framework Keywords:
Cc: Blocked By:
Blocking: Tester: Pete Peterson

Description (last modified by Martyn Gigg) (diff)

Recent changes have introduced some new warnings in

  • CalculateMSVesuvio and
  • CalculateGammaBackground
  • TobyFitResolutionModel

Change History

comment:1 Changed 6 years ago by Martyn Gigg

  • Status changed from new to assigned
  • Description modified (diff)
  • Summary changed from Fix cppcheck warnings in Veusvio curve fitting code to Fix cppcheck warnings in Vesuvio curve fitting code

comment:2 Changed 6 years ago by Martyn Gigg

  • Description modified (diff)
  • Summary changed from Fix cppcheck warnings in Vesuvio curve fitting code to Fix some recent coverity warnings

comment:3 Changed 6 years ago by Martyn Gigg

  • Status changed from assigned to inprogress

Fix coverity warning around boost::unordered_map

Refs #10472

Changeset: a834f6d86add3dde86678dda1d9616bef8573db7

comment:4 Changed 6 years ago by Martyn Gigg

Fix coverity warning by refactoring to use common helper function

Refs #10472

Changeset: 6fcfdc0db4e1fefe74505753c67966c68e515063

comment:5 Changed 6 years ago by Martyn Gigg

Fix bug picked up by coverity.

Refs #10472

Changeset: 1afc7d055da193d71246a18cf9b5e603da956ced

comment:6 Changed 6 years ago by Martyn Gigg

Removed unused variable that was detected by coverity.

Refs #10472

Changeset: 12947fe363a1fe4d09f9c9fb55c4107194ebacac

comment:7 Changed 6 years ago by Martyn Gigg

  • Status changed from inprogress to verify
  • Resolution set to fixed

This is being verified as ​pull request #57.

comment:8 Changed 6 years ago by Pete Peterson

  • Status changed from verify to verifying
  • Tester set to Pete Peterson

comment:9 Changed 6 years ago by Pete Peterson

  • Status changed from verifying to closed

Merge pull request #57 from mantidproject/bugfix/10472_coverity_fixes

Looks good to me

Full changeset: ​c0f160cfc2a91e5539582e037a1db4d8798ecabc

comment:10 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​11314

Note: See TracTickets for help on using tickets.