Ticket #10498 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

Add PhaseQuad algorithm

Reported by: Anders Markvardsen Owned by: Raquel Alvarez Banos
Priority: major Milestone: Release 3.3
Component: Muon Keywords:
Cc: stephen.cottrell@… Blocked By: #10577
Blocking: #10499 Tester: John Hill

Description

Add PhaseQuad algorithm, where the name of the .h and .cpp will be PhaseQuadMuon.h/.cpp. Add this to Muon group.

It takes the same parameters as http://docs.mantidproject.org/nightly/algorithms/ApplyDeadTimeCorr-v1.html but with PhaseTable instead of DeadTimeTable.

The input workspace is just any muon dataset.

The output contains two spectra.

Add unit test, .rst file with usage example.

This algorithm will be based on VAX c-code and article which Stephen will email.

Attachments

41779.txt (86.4 KB) - added by Raquel Alvarez Banos 6 years ago.
41780.txt (86.5 KB) - added by Raquel Alvarez Banos 6 years ago.
41781.txt (86.4 KB) - added by Raquel Alvarez Banos 6 years ago.
MUSR00041779.nxs (654.8 KB) - added by Raquel Alvarez Banos 6 years ago.
MUSR00041780.nxs (654.5 KB) - added by Raquel Alvarez Banos 6 years ago.
MUSR00041781.nxs (655.9 KB) - added by Raquel Alvarez Banos 6 years ago.
HISSDATA.INF (2.6 KB) - added by Raquel Alvarez Banos 6 years ago.

Change History

comment:1 Changed 6 years ago by Raquel Alvarez Banos

  • Blocking 10499 added

comment:2 Changed 6 years ago by Raquel Alvarez Banos

  • Blocked By 10577 added

comment:3 Changed 6 years ago by Raquel Alvarez Banos

Re #10498 Adding cpp h and CMakeList files

Changeset: 65d084f2be9c1847af1092d671172e5824496a6c

comment:4 Changed 6 years ago by Raquel Alvarez Banos

Re #10498 Working on Phase Quad Muon algorithm

Changeset: adab7006cbba4fac5fa04ca1be36bb0f7d859e81

comment:5 Changed 6 years ago by Martyn Gigg

  • Status changed from new to assigned

Changed 6 years ago by Raquel Alvarez Banos

Changed 6 years ago by Raquel Alvarez Banos

Changed 6 years ago by Raquel Alvarez Banos

Changed 6 years ago by Raquel Alvarez Banos

Changed 6 years ago by Raquel Alvarez Banos

Changed 6 years ago by Raquel Alvarez Banos

Changed 6 years ago by Raquel Alvarez Banos

comment:6 Changed 6 years ago by Raquel Alvarez Banos

  • Status changed from assigned to inprogress

Re #10498 PhaseQuad algorithm updated

Changeset: 71dc3775f990d41aa6af10eaf1ebf20e13431d90

comment:7 Changed 6 years ago by Raquel Alvarez Banos

Re #10498 PhaseQuad fixing X shift

Changeset: 14790f2b192d5c130b2f964a80938ba9ad26d4f7

comment:8 Changed 6 years ago by Raquel Alvarez Banos

Re #10498 Reducing scope of variable sig

Changeset: 7d552f21aefdc202ecca5256c663004054bc8497

comment:9 Changed 6 years ago by Raquel Alvarez Banos

Re #10498 fixing reorder warnings

Changeset: d8f3e5c348332d7fc3f45eab63092181106bcf49

comment:10 Changed 6 years ago by Raquel Alvarez Banos

Re #10498 Fixing comoparison signed unsigned warning

Changeset: adbdf84cd3870b2277529ebb4162ca7f1d78cd6d

comment:11 Changed 6 years ago by Raquel Alvarez Banos

For tester:

  • Open MUSR00041779.nxs attached.
  • Run PhaseQuad algorithm
  • Supply HISSDATA.INF (attached) as PhaseList in the input dialog
  • You should get an output workspace with two spectra
  • Optionally you may check that these spectra match (within error bars) the spectra in 41779.txt attached, except for the X values. To check this, just compare columns 2,3 (Y,E) in 41779.txt with Y,E values in the first spectrum in your output workspace, and columns 4,5 (Y,E) with the second spectrum.
  • Alternatively, you can provide a TableWorkspace as PhaseTable in the input dialog. This PhaseTable should have four columns (bool, double, double, double). The algorithm should work fine and create two spectra in the output workspace.
Last edited 6 years ago by Raquel Alvarez Banos (previous) (diff)

comment:12 Changed 6 years ago by Raquel Alvarez Banos

Re #10498 Adding note in documentation

Changeset: f7b15502d907839a60992f6e161a22335bc91b74

comment:13 Changed 6 years ago by Raquel Alvarez Banos

  • Status changed from inprogress to verify
  • Resolution set to fixed

comment:14 Changed 6 years ago by John Hill

  • Status changed from verify to verifying
  • Tester set to John Hill

comment:15 Changed 6 years ago by Raquel Alvarez Banos

Re #10498 fixing conflicts

Changeset: 7ca1a6c7b1026b647420ccb82d3eb4999e267446

comment:16 Changed 6 years ago by John Hill

Re #10498 merging branches

Changeset: 7b125b77af848dac547b2799e1f626354f60fb1d

comment:17 Changed 6 years ago by John Hill

  • Status changed from verifying to closed

comment:18 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 11340

Note: See TracTickets for help on using tickets.