Ticket #10549 (closed: fixed)
Create InternetService + DownloadFile Algorithm
| Reported by: | Nick Draper | Owned by: | Nick Draper |
|---|---|---|---|
| Priority: | major | Milestone: | Release 3.3 |
| Component: | Framework | Keywords: | |
| Cc: | petersonpf@… | Blocked By: | #10574 |
| Blocking: | #8924, #10559 | Tester: | Peter Peterson |
Description
Refactor HTTP and HTTPS access code to an InternetService singleton in Kernel.
Create an Generic DownloadFile Algorithm in DataHandling.
Download Instrument should use these.
Change History
comment:2 Changed 6 years ago by Nick Draper
- Status changed from assigned to inprogress
re #10549 create DownloadFile and InternetHelper
Changeset: bc77c8b78fc55cd68e0eefd96441d22a997c222f
comment:4 Changed 6 years ago by Nick Draper
To test
This should ideally be tested at both ISIS (on linux, or mac) and the SNS
- Unit tests should pass, particularly Kernel\InternetHelperTest and DataHandling\DownloadFile
- Doc test for DownloadFile should pass
- Run DownloadFile for a selection of addresses, both http:// and https://, and without the protocol specified, for example
- Try some failure cases too. (the timeout defaults to 30 sec)
- You can also override the automatic detection of the proxy
- add the following to mantid.user.properties
- proxy.host = wwwcache.rl.ac.uk [for isis]
- proxy.port = 8080
- Restart mantidplot
- the values should be used instead
- A simple test is to set them wrong and check that DownloadFile fails.
- add the following to mantid.user.properties
comment:9 Changed 6 years ago by Martyn Gigg
- Status changed from inprogress to verify
- Owner changed from Nick Draper to Martyn Gigg
- Resolution set to fixed
comment:11 Changed 6 years ago by Harry Jeffery
- Status changed from verify to verifying
- Tester set to Harry Jeffery
comment:12 Changed 6 years ago by Harry Jeffery
Merge conflict in ConfigService.h and ConfigService.cpp.
comment:13 Changed 6 years ago by Harry Jeffery
- Status changed from verifying to verify
- Tester Harry Jeffery deleted
comment:14 Changed 6 years ago by Nick Draper
re #10549 merge master and resolve conflict
Changeset: e5aa71c68159a8cf910bcc4dec46c403e8ee252d
comment:15 Changed 6 years ago by Nick Draper
re #10549 resolve linux error
Changeset: 778af513aff3c014f639ec91d4a0341bb795a8fe
comment:16 Changed 6 years ago by Nick Draper
re #10549 mac only error
Changeset: f3dae87545b6fc3978334f3dc190f6ebab32cad9
comment:17 Changed 6 years ago by Nick Draper
re #10549 Fix warning
Changeset: 8450787b233cb81fee1cb7776982d04dc4e0b2a4
comment:18 Changed 6 years ago by Nick Draper
Ready for testing again
comment:19 Changed 6 years ago by Harry Jeffery
- Status changed from verify to verifying
- Tester set to Harry Jeffery
comment:20 Changed 6 years ago by Harry Jeffery
- Status changed from verifying to verify
- Tester Harry Jeffery deleted
Working as expected on Ubuntu 14.04
comment:21 Changed 6 years ago by Peter Peterson
- Status changed from verify to verifying
- Tester set to Peter Peterson
It looks good with my tests. My one question is how do we get users to not be confused between this algorithm and DownloadRemoteFile.
comment:22 Changed 6 years ago by Pete Peterson
- Status changed from verifying to closed
Merge remote-tracking branch 'origin/feature/10549_Internet_Service'
Full changeset: 9fbe93276b4e9fbcc8912a13f26d27eeade10aef
comment:23 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 11391
As discussed this won't be a singleton but a standard class and the proxy info will be cached by the ConfigService