Ticket #10566 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

Add ConfigService::getOSVersionReadable()

Reported by: Peter Peterson Owned by: Peter Peterson
Priority: major Milestone: Release 3.3
Component: Framework Keywords:
Cc: Blocked By:
Blocking: #10559 Tester: Martyn Gigg

Description (last modified by Peter Peterson) (diff)

For the usage statistics, it is useful to have a better string for the os. This will be platform dependent.

  • For OSX use sysctl.h and an if/else tree to map kernel to versions ​link and ​wikipedia
  • For linuxes use the line PRETTY_NAME from /etc/os-release (or \etc\redhat-release)
  • For windows, include windows.h and have a long if/else related to ​OSVERSIONINFOEX structure The major minor version formats could be done from information ​here

Change History

comment:1 Changed 6 years ago by Peter Peterson

  • Description modified (diff)

comment:2 Changed 6 years ago by Andrei Savici

You can get Windows version from command line ​http://www.windows-commandline.com/find-windows-os-version-from-command/

comment:3 Changed 6 years ago by Peter Peterson

  • Status changed from new to assigned

comment:4 Changed 6 years ago by Peter Peterson

  • Description modified (diff)

comment:5 Changed 6 years ago by Peter Peterson

  • Description modified (diff)

comment:6 Changed 6 years ago by Peter Peterson

  • Description modified (diff)

comment:7 Changed 6 years ago by Pete Peterson

  • Status changed from assigned to inprogress

Refs #10566. Adding linux version of getOSVersionReadable.

Changeset: b1cc3b07a0711883d5fe39a41bc262d8bafad6d8

comment:8 Changed 6 years ago by Pete Peterson

Refs #10566. Adding code that should work for mac and windoze

Changeset: dceb3ea7d973c745c6007016fc3722d09b3f0ce3

comment:9 Changed 6 years ago by Pete Peterson

Re #10566. Adding implementation for windows and mac.

Changeset: 6cdb998d3a00f7dfffedba60482ec46c1bf04263

comment:10 Changed 6 years ago by Pete Peterson

  • Status changed from inprogress to verify
  • Resolution set to fixed

This is being verified as ​pull request #69.

comment:11 Changed 6 years ago by Pete Peterson

Don't test this yet. There is still a little bit of cleanup left and I'm trying to see that the cross-platform part works.

comment:12 Changed 6 years ago by Pete Peterson

Refs #10566. Check for the files on every os.

Changeset: e540d5ef83187433237072097009dece16f84d66

comment:13 Changed 6 years ago by Pete Peterson

retest this please

comment:14 Changed 6 years ago by Pete Peterson

retest this please

comment:15 Changed 6 years ago by Pete Peterson

retest this please

comment:16 Changed 6 years ago by Pete Peterson

The builds finally agreed that I know what I'm doing. It is ready to be merged into master now.

comment:17 Changed 6 years ago by Martyn Gigg

  • Status changed from verify to verifying
  • Tester set to Martyn Gigg

comment:18 Changed 6 years ago by Pete Peterson

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/master' into feature/10566_getOSVersionReable

Full changeset: ​8150cbd16c4c064ecfea6af1e26da59838611119

comment:19 Changed 6 years ago by Pete Peterson

Merge remote-tracking branch 'origin/master' into feature/10566_getOSVersionReable

Full changeset: ​19a36fbc3186364c92084ea0dce2e0e558a38d81

comment:20 Changed 6 years ago by Martyn Gigg

Merge pull request #69 from mantidproject/feature/10566_getOSVersionReable

Add ConfigService::getOSVersionReadable()

Full changeset: ​86f406562948ba4228aa43f7ed0d055e821f7d87

comment:21 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​11408

Note: See TracTickets for help on using tickets.