Ticket #10601 (closed: wontfix)

Opened 6 years ago

Last modified 5 years ago

Allow SofQW2 to accept a vertical numeric axis of Q/angle

Reported by: Martyn Gigg Owned by: Dan Nixon
Priority: critical Milestone: Release 3.3
Component: Indirect Inelastic Keywords:
Cc: Blocked By:
Blocking: Tester: Federico M Pouzols

Description (last modified by Martyn Gigg) (diff)

Spencer Howells has a use case for BASIS where there input to SofQW is a workspace with a numeric vertical axis that contains the Q values.

At the moment SofQW requires a vertical spectrum axis to get access to the detector information. However, all it does with the vertical axis is compute the angles from it so we should generalise it to inspect the axis and if

  • SpectrumAxis then do what it does currently;
  • NumericAxis
    • Q values - Should be simpler as we don't need to do any Q calculation
    • Angle - Store these in the cache rather than computing it from the detector. The efixed then has to come from the instrument parameter or throw if not there

Change History

comment:1 Changed 6 years ago by Martyn Gigg

  • Status changed from new to assigned
  • Owner changed from Martyn Gigg to Dan Nixon
  • Description modified (diff)

comment:2 Changed 6 years ago by Martyn Gigg

  • Summary changed from Allow SofQW1/2 to accept a vertical numeric axis of Q/angle to Allow SofQW2 to accept a vertical numeric axis of Q/angle

comment:3 Changed 6 years ago by Dan Nixon

  • Status changed from assigned to inprogress

Work in progress, uses angles from Q in hist axis

Refs #10601

Changeset: c7495d98f60a92793cda9f6316adbbe4376c0886

comment:4 Changed 6 years ago by Dan Nixon

Fix some compile errors

Refs #10601

Changeset: 06f72cb4f88897292ea8c95d61a2b27f6eb006e5

comment:5 Changed 6 years ago by Dan Nixon

  • Status changed from inprogress to verify
  • Resolution set to wontfix

After discussion with Spencer it seems #10598 will fix this problem as this allows the GetThetaQ routine in IndirectCommon.py to get correct Q values using the detector information.

comment:6 Changed 6 years ago by Federico M Pouzols

  • Status changed from verify to verifying
  • Tester set to Federico M Pouzols

comment:7 Changed 6 years ago by Federico M Pouzols

  • Status changed from verifying to closed

A ticket that was closed recently seems to be an acceptable solution for this.

comment:8 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​11443

Note: See TracTickets for help on using tickets.