Ticket #10603 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

Replace Poco::RegularExpression with boost::regex in EQSANSLoad

Reported by: Martyn Gigg Owned by: Martyn Gigg
Priority: blocker Milestone: Release 3.3
Component: Framework Keywords:
Cc: Blocked By:
Blocking: Tester: Pete Peterson

Description

Poco::RegularExpression is broken in the 1.4.2 version on Ubuntu, which has caused system test failures: 

04:28:45 FAILED:
04:28:45 EQSANSIQOutputAPIv2.EQSANSBeamMonitor
04:28:45 EQSANSProcessedEffAPIv2.EQSANSProcessedEff
04:28:45 EQSANSNormalisationAPIv2.EQSANSNormalisationDefault
04:28:45 EQSANSNormalisationAPIv2.EQSANSNormalisationNoFlux
04:28:45 EQSANSIQOutputAPIv2.EQSANSDQOutput
04:28:45 EQSANSIQOutputAPIv2.EQSANSDQPositiveOutput
04:28:45 EQSANSDarkCurrentAPIv2.EQSANSDarkCurrent
04:28:45 EQSANSTransAPIv2.EQSANSTransmission
04:28:45 EQSANSTransAPIv2.EQSANSTransmissionCompatibility
04:28:45 EQSANSTransAPIv2.EQSANSTransmissionEvent
04:28:45 EQSANSSolidAPIv2.EQSANSSolid
04:28:45 EQSANSEffAPIv2.EQSANSEff
04:28:45 EQSANSBeamCenterAPIv2.EQSANSBeamCenter
04:28:45 EQSANSBeamCenterAPIv2.EQSANSBeamCenterEvent

A snippet of one of the failures: 

EQSANSLoad-[Notice] EQSANSLoad started
04:03:47 EQSANSLoad-[Notice] EQSANSLoad successful, Duration 0.53 seconds
04:03:47 SANSBeamFinder-[Notice] SANSBeamFinder successful, Duration 0.88 seconds
04:03:47 EQSANSLoad-[Notice] EQSANSLoad started
04:03:47 EQSANSLoad-[Error] Error in execution of algorithm EQSANSLoad:
04:03:47 EQSANSLoad-[Error] Error in regular expression
04:03:47 SANSReduction-[Error] Error in execution of algorithm SANSReduction
04:03:47 SANSReduction-[Error] Error in regular expression
04:03:47 SANSReduction-[Error]   at line 20 in '/opt/mantidnightly/plugins/python/algorithms/WorkflowAlgorithms/SANSReduction.py'
04:03:47 SANSReduction-[Error]   caused by line 101 in '/opt/mantidnightly/plugins/python/algorithms/WorkflowAlgorithms/SANSReduction.py'
04:03:47 SANSReduction-[Error]   caused by line 77 in '/opt/mantidnightly/plugins/python/algorithms/WorkflowAlgorithms/SANSReduction.py'
04:03:47 SANSReduction-[Error]   caused by line 47 in '/opt/mantidnightly/plugins/python/algorithms/WorkflowAlgorithms/SANSReduction.py'

This has been observed in other situations and fixed on other systems but it's not completely clear why these only fail here.

Change History

comment:1 Changed 6 years ago by Martyn Gigg

  • Status changed from new to assigned

comment:2 Changed 6 years ago by Martyn Gigg

  • Status changed from assigned to inprogress

Replace Poco::RegularExpression with boost::regex

Refs #10603

Changeset: 08d2a25cdc86b2f5e328261da7af8290f6c04114

comment:3 Changed 6 years ago by Martyn Gigg

Use boost::regex_search and not boost::regex_match

The latter requires everything to match, but we just want to search within a string. This is more like what Poco did. Refs #10603

Changeset: 8982f702e6d15c51db4f5d5f4b60a386ee34bc16

comment:4 Changed 6 years ago by Martyn Gigg

  • Status changed from inprogress to verify
  • Resolution set to fixed

This is being verified as ​pull request #74.

comment:5 Changed 6 years ago by Harry Jeffery

  • Status changed from verify to verifying
  • Tester set to Harry Jeffery

comment:6 Changed 6 years ago by Martyn Gigg

  • Status changed from verifying to verify
  • Tester Harry Jeffery deleted

comment:7 Changed 6 years ago by Pete Peterson

  • Status changed from verify to verifying
  • Tester set to Pete Peterson

comment:8 Changed 6 years ago by Pete Peterson

  • Status changed from verifying to closed

Merge pull request #74 from mantidproject/bugfix/10603_eqsansload_regex

Switch to boost::regex in EQSANSLoad

Full changeset: ​f00d474e6d86720095cbbdc964cef43ef910b3a5

comment:9 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​11445

Note: See TracTickets for help on using tickets.