Ticket #10607 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

Display Mask Throws Error on Recent SANS2D Data

Reported by: Peter Parker Owned by: Peter Parker
Priority: critical Milestone: Release 3.3
Component: Framework Keywords:
Cc: anders.markvardsen@…, richard.heenan@… Blocked By:
Blocking: Tester: Roman Tolchenov

Description

Richard has pointed out that in nightly build 3.2.20141113.1844, the "Display Mask" fails with the following error message: 

FindDeadDetectors started
Found a total of 58014 'dead' detectors within 58014 'dead' spectra.
FindDeadDetectors successful, Duration 0.66 seconds
CreateWorkspace started
Invalid value for VerticalAxisValues: Axis values cannot be provided when using a spectra axis
RuntimeError: Some invalid Properties found
  at line 7 in '<Interface>'
  caused by line 969 in 'C:/MantidInstall/scripts/SANS\ISISCommandInterface.py'
  caused by line 1040 in 'C:/MantidInstall/scripts/SANS\isis_reduction_steps.py'
  caused by line 569 in 'C:/MantidInstall/bin\mantid\simpleapi.py'

He also confirmed that no such error was thrown in 3.2, so this is a regression.

I was able to reproduce with run SANS2D00027142 and MASKSANS2D_135E_tubecalib_M3v11.txt (a user file I picked arbitrarily).

Change History

comment:1 Changed 6 years ago by Peter Parker

A quick grep for the error message reveals that this a direct result of changes made in #10534.

comment:2 Changed 6 years ago by Peter Parker

Refs #10607 - Remove erroneous use of VerticalAxisValues property.

Changeset: de29037ced72ebfe6f47e37b0591e0749f69ebee

comment:3 Changed 6 years ago by Martyn Gigg

  • Status changed from new to assigned

comment:4 Changed 6 years ago by Peter Parker

  • Status changed from assigned to verify
  • Resolution set to fixed

I've created #10607 to cover Display Mask with a system test (this requires some refactoring and is not something I have any time to do now).

Otherwise this issue should be fixed. To test (ISIS only):

  • Add //isis/inst$/Instruments$/NDXSANS2D/user/Masks/ to Mantid's Managed Directories.
  • Open up the ISIS SANS interface and select the "SANS2DTUBES" instrument.
  • Load the MASKSANS2D_135E_tubecalib_M3v11.txt User File from the directory you added previously using the "Load Mask" button. This may take a while. You'll know it's finished loading when a dialog pops up.
  • In the "Sample" field of the "Scattering" group box, navigate to SANS2D00027142.raw in the archive.
  • Press "Load Data".
  • Go to the "Masking" tab and click "Display Mask".

The Instrument View should now appear, rather the error we were seeing previously.

comment:5 Changed 6 years ago by Roman Tolchenov

  • Status changed from verify to verifying
  • Tester set to Roman Tolchenov

comment:6 Changed 6 years ago by Roman Tolchenov

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/bugfix/10607_isis_sans_display_mask_throws_error_on_sans2d_data'

Full changeset: ​1cc88bc7b01604aacf4a4a16607f40576952435b

comment:7 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​11449

Note: See TracTickets for help on using tickets.