Ticket #10622 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

Load HFIR HB2A data

Reported by: Wenduo Zhou Owned by: Wenduo Zhou
Priority: major Milestone: Release 3.4
Component: Framework Keywords:
Cc: petersonpf@…, saviciat@… Blocked By: #10554, #10835, #10928
Blocking: Tester: Vickie Lynch

Description

Load HFIR HB2A data to Mantid. The task includes generating an instrument definition file and creating a Workspace2D for it.

Change History

comment:1 Changed 6 years ago by Wenduo Zhou

  • Status changed from new to assigned

comment:2 Changed 6 years ago by Wenduo Zhou

  • Status changed from assigned to inprogress

comment:3 Changed 6 years ago by Nick Draper

Moved to the backlog at the code freeze of R3.3

comment:4 Changed 6 years ago by Nick Draper

  • Milestone changed from Release 3.3 to Backlog

comment:5 Changed 6 years ago by Wenduo Zhou

  • Milestone changed from Backlog to Release 3.4

comment:6 Changed 6 years ago by Wenduo Zhou

Refs #10622. Add instrument def of HB2A.

  • new file: HB2A_Definition.xml (IDF)
  • new file: HB2A_exp0379gaps.txt (Gap file)
  • new file: hb2a_generator.py (IDF generator)

Changeset: 05fdfb89068117370e813ca676d617a595ce0fa6

Last edited 6 years ago by Wenduo Zhou (previous) (diff)

comment:7 Changed 6 years ago by Wenduo Zhou

  • Blocked By 10835 added

comment:8 Changed 6 years ago by Wenduo Zhou

Refs #10622. Added algorithm to load HFIR PDD.

  • new file: Framework/DataHandling/inc/MantidDataHandling/LoadHFIRPDD.h
  • new file: Framework/DataHandling/src/LoadHFIRPDD.cpp
  • new file: Framework/DataHandling/test/LoadHFIRPDDTest.h

Changeset: e17aa2cdd1c57c7127d42f6ff140f48f9c13353e

comment:9 Changed 6 years ago by Wenduo Zhou

Refs #10622. Modified CMake file.

Changeset: 6de15229ebce402083d83b993d2c5716b62ea403

comment:10 Changed 6 years ago by Wenduo Zhou

Refs #10622. Checkpointing the progress of implementation.

Changeset: 4d5109cbe763da2836fd1fb0d618f680ab57e59b

comment:11 Changed 6 years ago by Wenduo Zhou

Minor modifed and test with clang. Refs #10622.

Changeset: 43dd54d7d02226383256f41222773a0f7c51a0f3

comment:12 Changed 6 years ago by Wenduo Zhou

Refs #10622. Checkpointing progress on compiling.

Changeset: a8ee2637f9e384742f838287b3b948ada735208b

comment:13 Changed 6 years ago by Wenduo Zhou

Refs #10622. Checkpointing some progress.

Changeset: 046402fc1ee2e30b26f148240330d71fcaf71373

comment:14 Changed 6 years ago by Wenduo Zhou

Refs #10622. Checkpointing some modification.

Changeset: 4ead668b22e88cbe567d4c24af32eeb5a657872f

comment:15 Changed 6 years ago by Wenduo Zhou

Changed input properties. Refs #10622.

Changeset: 3bbbe5060f3230795781fa7cc05869e4ed6d7e3c

comment:16 Changed 6 years ago by Wenduo Zhou

Refs #10622. Fixed some error with unit test.

Changeset: 7c49d70bfb2a46c84d8697f94450eb44176ed4ea

comment:17 Changed 6 years ago by Wenduo Zhou

Added some TODO information. Refs #10622.

Changeset: 07a996db853d96c48d3c85b2218491834dfda96e

comment:18 Changed 6 years ago by Wenduo Zhou

Refs #10622. Moved to MDAlgorithms.

Changeset: b558c66375bb91059bc0bd2322ff91598206e873

comment:19 Changed 6 years ago by Wenduo Zhou

Implemented to add sample logs. Refs #10622.

Changeset: a2dbb0b7898e9f72220ef9e28682189d23c7921c

comment:20 Changed 6 years ago by Wenduo Zhou

Refs #10622. Checkpoing work for reducing pd data.

Changeset: c2d1bd5955631a7e908522908d8eb07e3fdfadc8

comment:21 Changed 6 years ago by Wenduo Zhou

Enabled to reduce powder data. Refs #10622.

Changeset: 844d56178beea67fcfb5b2ff31d0e5a9e16f2a6c

comment:22 Changed 6 years ago by Wenduo Zhou

  • Blocked By 10928 added

comment:23 Changed 6 years ago by Wenduo Zhou

  • Blocking 10929 added

comment:24 Changed 6 years ago by Wenduo Zhou

Checkpoint work to fix errors pass unit test. Refs #10622.

Changeset: 134aaa5febe3a5ecda808eeaf9c4ef765c5bd2b5

comment:25 Changed 6 years ago by Wenduo Zhou

Refs #10622. Added methods to create instrument in MDWorkspace.

Changeset: e18a6edbd8a2545967ac23cc9f7741ba01294ddd

comment:26 Changed 6 years ago by Wenduo Zhou

Fixed the error causing core dump. Refs #10622.

On branch feature/10622_load_hb2a Changes to be committed:

  • modified: ../Mantid/Framework/MDAlgorithms/src/LoadHFIRPDD.cpp
  • modified: ../Mantid/Framework/MDAlgorithms/test/LoadHFIRPDDTest.h

Changeset: 04b0c23e009587dd09fc5c4b65c90952a0b915fe

comment:27 Changed 6 years ago by Wenduo Zhou

The codes implemented in this ticket are the prototype to load and reduce data from HFIR's diffractometers.

It turned out that the codes grew too large for other developer to test. Therefore, the development on this ticket is aborted. And tickets ##10835, #10555 and #10929 are the replacements of it.

And this ticket is claimed 'duplicate'. And the branch can be deleted from github.

Last edited 6 years ago by Wenduo Zhou (previous) (diff)

comment:28 Changed 6 years ago by Wenduo Zhou

  • Blocking 10929 removed

comment:29 Changed 6 years ago by Wenduo Zhou

  • Status changed from inprogress to verify
  • Resolution set to duplicate

comment:30 Changed 6 years ago by Vickie Lynch

  • Status changed from verify to verifying
  • Tester set to Vickie Lynch

comment:31 Changed 6 years ago by Vickie Lynch

  • Status changed from verifying to closed

comment:32 Changed 5 years ago by Nick Draper

  • Resolution changed from duplicate to fixed

Somehow these slipped through without a resolution. Set to Fixed.

comment:33 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​11464

Note: See TracTickets for help on using tickets.