Ticket #10635 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

fix compiler warning in master

Reported by: Steven Hahn Owned by: Steven Hahn
Priority: major Milestone: Release 3.3
Component: Framework Keywords:
Cc: Blocked By:
Blocking: Tester: Wenduo Zhou

Description (last modified by Steven Hahn) (diff)

A compiler warning slipped into master. m_useProcessScript is a bool, so it should be initialized true/false.

/Users/svh/Documents/MantidProject/mantid/Code/Mantid/MantidQt/CustomDialogs/src/StartLiveDataDialog.cpp:75:47: warning: implicit conversion of NULL constant to 'bool' [-Wnull-conversion]

m_useProcessAlgo(false), m_useProcessScript(NULL),

~~

false

1 warning generated.

Change History

comment:1 Changed 6 years ago by Steven Hahn

  • Description modified (diff)

comment:2 Changed 6 years ago by Steven Hahn

Refs #10635. remove implicit conversion

Changeset: e9aa2e9c2f80c173e5152ccfe8835d0bfb7ac40f

comment:3 Changed 6 years ago by Steven Hahn

  • Status changed from new to verify
  • Resolution set to fixed

This is being verified as ​pull request #80.

comment:4 Changed 6 years ago by Wenduo Zhou

  • Status changed from verify to verifying
  • Tester set to Wenduo Zhou

comment:5 Changed 6 years ago by Wenduo Zhou

  • Status changed from verifying to closed

Merge pull request #80 from mantidproject/feature/10635_fix_compiler_warning

remove implicit conversion from NULL to false

Full changeset: ​36f0c71a21981b60fa6dab57d9460ac01f7a1fd4

comment:6 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​11477

Note: See TracTickets for help on using tickets.