Ticket #10659 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

Fix ISIS Reflectometry algorithm categories

Reported by: Harry Jeffery Owned by: Harry Jeffery
Priority: minor Milestone: Release 3.3
Component: Framework Keywords:
Cc: Blocked By:
Blocking: Tester: Nick Draper

Description (last modified by Harry Jeffery) (diff)

The following algorithms should be in the Reflectometry category:

  • ReflectometryReductionOne
  • CreateTransmissionWorkspace
  • SpecularReflectionCalculateTheta
  • PolarizationCorrection
  • SpecularReflectionPositionCorrect
  • ConvertToReflectometryQ
  • FindReflectometryLines

The following algorithms should document their use of sample log values:

  • ConvertToReflectometryQ

Change History

comment:1 Changed 6 years ago by Harry Jeffery

  • Status changed from new to assigned

comment:2 Changed 6 years ago by Harry Jeffery

  • Status changed from assigned to inprogress

comment:3 Changed 6 years ago by Harry Jeffery

Refs #10659 Fix polarization correction category

Changeset: 4c762c28882fd7a0dfcab12cd72ee8d91f85488c

comment:4 Changed 6 years ago by Harry Jeffery

  • Status changed from inprogress to verify
  • Resolution set to fixed

Testing

  • Inspect changes
  • Check the algorithms window, ensure the PolarizationCorrection algorithm is now in the right category.

comment:5 Changed 6 years ago by Harry Jeffery

  • Status changed from verify to reopened
  • Resolution fixed deleted

comment:6 Changed 6 years ago by Harry Jeffery

  • Status changed from reopened to inprogress
  • Description modified (diff)
  • Summary changed from Fix category of PolarizationCorrection algorithm to Fix ISIS Reflectometry algorithm categories

Expanding this ticket to include other category adjustments

comment:7 Changed 6 years ago by Harry Jeffery

  • Description modified (diff)

comment:8 Changed 6 years ago by Harry Jeffery

  • Description modified (diff)

comment:9 Changed 6 years ago by Harry Jeffery

Refs #10659 Update some Refl algorithm categories

Changeset: c4612dc802ca8da67b825ccd8074c408d0ee27c2

comment:10 Changed 6 years ago by Harry Jeffery

Testing

  • Inspect changes
  • Verify algorithms are now in the correct categories

comment:11 Changed 6 years ago by Harry Jeffery

  • Status changed from inprogress to verify
  • Resolution set to fixed

comment:12 Changed 6 years ago by Roman Tolchenov

ConvertToReflectometryQ test is failing

comment:13 Changed 6 years ago by Harry Jeffery

Refs #10659 Remove failing overzealous test

Changeset: 47e27bcdbaa67c4bb5938a38cfdd727c8fb2b902

comment:14 Changed 6 years ago by Nick Draper

  • Status changed from verify to verifying
  • Tester set to Nick Draper

comment:15 Changed 6 years ago by Nick Draper

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/feature/10659_fix_polcor_category'

Full changeset: ​903d5bf060424fdcc98810bde73794e3ea6da832

comment:16 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​11501

Note: See TracTickets for help on using tickets.