Ticket #10668 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

Fitting with counts/bin width normalised data

Reported by: Nick Draper Owned by: Roman Tolchenov
Priority: critical Milestone: Release 3.3
Component: Framework Keywords:
Cc: Blocked By: #10639
Blocking: Tester: Martyn Gigg

Description

The interaction with fitting is confusing as you setup the plot against normalized data, but it fits against the underlying non normalized data.

This script creates test workspaces

uniform_bins = CreateSampleWorkspace()
non_uniform_bins = Rebin(uniform_bins, Params="0,300,10000,500,20000")
point_data = ConvertToPointData(uniform_bins)
non_uniform_bins_distrib = non_uniform_bins.clone()
ConvertToDistribution(non_uniform_bins_distrib)

Attachments

test1.py (219 bytes) - added by Roman Tolchenov 6 years ago.

Change History

comment:1 Changed 6 years ago by Nick Draper

  • Blocked By 10639 added

(In #10639) Reopened due to a few issues: only the first should be dealt with in this ticket, the others have new tickets.

  1. If you plot errors, whether by plotspectrum with errors, or the graph->add error bars -> from workspace, they are not scaled by the bin width and therefore overpower the data.
  2. The interaction with fitting is confusing as you setup the plot against normalized data, but it fits against the underlying non normalized data. - Follow on ticket to deal with this #10668.
  3. We need to make sure the default is set "correctly" for this release - Follow on ticket to determine this and implement #10669.

comment:2 Changed 6 years ago by Nick Draper

  • Status changed from new to assigned

comment:3 Changed 6 years ago by Roman Tolchenov

  • Status changed from assigned to inprogress

Re #10668. Fit browser passes an option to Fit to normalise data.

Changeset: 9efbf2c9e4dd496246989169ab9073945b7d798d

comment:4 Changed 6 years ago by Roman Tolchenov

Re #10668. Unit test for data normalisation.

Changeset: fee637561e08cb4430307671a61ee581a93b704d

Changed 6 years ago by Roman Tolchenov

comment:5 Changed 6 years ago by Roman Tolchenov

  • Status changed from inprogress to verify
  • Resolution set to fixed

To test

  1. Run the attached script to create a non-uniform test workspace.
  2. Fit the data using the graphical fitting tool with normalisation on and off.
  3. Check that fitting works correctly in both cases.

comment:6 Changed 6 years ago by Roman Tolchenov

Re #10668. Fix doxygen warning.

Changeset: 0ec3dc54ffdee84f002bf917b7c4f061b63c24bd

comment:7 Changed 6 years ago by Martyn Gigg

  • Status changed from verify to verifying
  • Tester set to Martyn Gigg

comment:8 Changed 6 years ago by Martyn Gigg

  • Status changed from verifying to closed

Merge branch 'feature/10668_fitting_normalised_data'

Full changeset: 27ffc73d3634b9ae3998dde61a0180ef24f6f7a9

comment:9 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 11510

Note: See TracTickets for help on using tickets.