Ticket #10671 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

Symmetrise algorithm and UI bugs

Reported by: Dan Nixon Owned by: Dan Nixon
Priority: blocker Milestone: Release 3.3
Component: Indirect Inelastic Keywords:
Cc: Blocked By:
Blocking: Tester: Harry Jeffery

Description (last modified by Dan Nixon) (diff)

After correcting issue to preserve axis units and values the algorithm now fails if a spectra range is given as it attempts to copy the entire vertical axis to a workspace containing fewer spectra.

Also the UI does not set the output table property so preview properties are not updated when clicking "Run".

These two issues combined make the Symmetrise tab on IDR unusable.

Change History

comment:1 Changed 6 years ago by Dan Nixon

  • Description modified (diff)

comment:2 Changed 6 years ago by Dan Nixon

  • Status changed from new to assigned

comment:3 Changed 6 years ago by Dan Nixon

  • Summary changed from Symmetrise algorithm bugs to Symmetrise algorithm and UI bugs

comment:4 Changed 6 years ago by Dan Nixon

  • Status changed from assigned to inprogress

Correct issues with Symm algo and UI

Refs #10671

Changeset: 3f38674ad3ab04cf8e50e1c5cb95562f772dbb80

comment:5 Changed 6 years ago by Dan Nixon

Unit test the dodgy functionality

Refs #10671

Changeset: 690c7859ef4a79ec5135450554863e5e76d795f2

comment:6 Changed 6 years ago by Dan Nixon

To test:

  • Ensure unit test is passing (SymmetriseTest)
  • Ensure doc test is passing
  • Review documentation changes, it should not mention specifics related to indiretc but just talk about the changes the algorithm makes to the data
  • Load a reduced file into Indirect > Data Reduction > Symmetrise
  • Run the Preview option
  • Delete the properties table (must enable show hidden workspaces)
  • Click Run
Last edited 6 years ago by Dan Nixon (previous) (diff)

comment:7 Changed 6 years ago by Dan Nixon

  • Status changed from inprogress to verify
  • Resolution set to fixed

comment:8 Changed 6 years ago by Harry Jeffery

  • Status changed from verify to verifying
  • Tester set to Harry Jeffery

comment:9 Changed 6 years ago by Harry Jeffery

  • Status changed from verifying to verify
  • Tester Harry Jeffery deleted

comment:10 Changed 6 years ago by Andrei Savici

You should change the name of the algorithm. Symmetrise name implies something more general that this algorithm

comment:11 Changed 6 years ago by Dan Nixon

I could just prefix it with Indirect but there is nothing stopping this algorithm being used with any matrix workspace.

If anything I think the documentation is too specific to it's use in indirect.

Last edited 6 years ago by Dan Nixon (previous) (diff)

comment:12 Changed 6 years ago by Dan Nixon

  • Status changed from verify to reopened
  • Resolution fixed deleted

I may as well improve the docs now.

comment:13 Changed 6 years ago by Dan Nixon

  • Status changed from reopened to inprogress

Make Symmetrise docs more generic

Refs #10671

Changeset: 04a8da0253be29d7eb8c8ae28275ebb85734a3d2

comment:14 Changed 6 years ago by Dan Nixon

  • Status changed from inprogress to verify
  • Resolution set to fixed

comment:15 Changed 6 years ago by Dan Nixon

Correct spelling mistake

Refs #10671

Changeset: 9b20614ddbb61b2f00bf1866b5aebbbc8afaf871

comment:16 Changed 6 years ago by Harry Jeffery

  • Status changed from verify to verifying
  • Tester set to Harry Jeffery

comment:17 Changed 6 years ago by Dan Nixon

Clarify what the data is made symmetrical about

Refs #10671

Changeset: 4675755b4ccc1fd0d0d41863d9e549428e604d70

comment:18 Changed 6 years ago by Harry Jeffery

This ticket doesn't introduce or give Symmetrise its name, it's only improving the documentation and robustness of it. If it needs to be renamed, that should probably go in another ticket.

Passed testing.

comment:19 Changed 6 years ago by Harry Jeffery

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/bugfix/10671_symmetrise_ui_and_algo_bugs'

Full changeset: ​cd9841f8765ea01d750af93b61bcabc33e6cd733

comment:20 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​11513

Note: See TracTickets for help on using tickets.