Ticket #10690 (closed: fixed)
Build packages in RelWithDbgInfo by default
| Reported by: | Martyn Gigg | Owned by: | Martyn Gigg |
|---|---|---|---|
| Priority: | major | Milestone: | Release 3.3 |
| Component: | Framework | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | Tester: | Harry Jeffery |
Description
For nightly and unstable packages it is useful to have debugging symbols within the libraries. For release packages it will be set to Release.
Change History
comment:2 Changed 6 years ago by Martyn Gigg
- Status changed from assigned to inprogress
Use RelWithDbgInfo as default build type for build servers
Refs #10690
Changeset: c1ffd510bb2b54d67c66d0bd3095c12745fb619f
comment:3 Changed 6 years ago by Martyn Gigg
- Status changed from inprogress to verify
- Resolution set to fixed
This is being verified as pull request #84.
comment:4 Changed 6 years ago by Harry Jeffery
- Status changed from verify to verifying
- Tester set to Harry Jeffery
comment:7 Changed 6 years ago by Harry Jeffery
- Status changed from verifying to closed
Merge pull request #84 from mantidproject/feature/10690_relwithdbg_package_builds
Use RelWithDbgInfo as default build type for build servers
Full changeset: 19a1a866e74f630aaa0b28bc529f371e75c32963
comment:8 Changed 6 years ago by Martyn Gigg
@eXeC64: Any reason this was merged before the builds marked it okay?
comment:9 Changed 6 years ago by Harry Jeffery
@martyngigg: I reviewed the changes, and the logs from the builds, and http://builds.mantidproject.org/job/pull_requests/173/ showed the OS X, rhel6, and Ubuntu builds to be well under way before they were aborted (due to the rhel6 machine running out of disk space). Given the nature of the changes, if they had been breaking, the build wouldn't have gotten off the ground.
Combined with the ticket itself saying that "Code review should be sufficient here", I felt I'd seen sufficient evidence that the changes were correct.
comment:10 Changed 6 years ago by Martyn Gigg
Okay. For future issues it would be good to put a comment in to that effect when merging. Thanks
comment:11 Changed 6 years ago by Harry Jeffery
Okay, I'll be sure to do that in future.
comment:12 Changed 6 years ago by Pete Peterson
This has ballooned all of the libraries. I'm suspicious it is because we are over-linking/exporting things. I'm reverting and reopening.
comment:13 Changed 6 years ago by Pete Peterson
- Status changed from closed to verify
This is being verified as pull request #88.
comment:14 Changed 6 years ago by Pete Peterson
@martyngigg This changes the .so from ~10M to ~100M. We need to figure out how to reduce our exported symbols first.
comment:15 Changed 6 years ago by Pete Peterson
- Status changed from verify to closed
Merge pull request #88 from mantidproject/revert-84-feature/10690_relwithdbg_package_builds
Revert "Use RelWithDbgInfo as default build type for build servers"
Full changeset: da9b5042ba5ff7140b113d53934c66745ed2613a
comment:16 Changed 6 years ago by Martyn Gigg
Okay. Something to revisit after we sort out the linking mess.
On Fri, 5 Dec 2014 18:30 Pete Peterson <notifications@…> wrote:
This has ballooned all of the libraries. I'm suspicious it is because we are over-linking/exporting things. I'm reverting and reopening.
— Reply to this email directly or view it on GitHub <https://github.com/mantidproject/mantid/pull/84#issuecomment-65833027>.
comment:17 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 11532
