Ticket #10797 (closed: fixed)

Opened 6 years ago

Last modified 6 years ago

Improve logging

Reported by: MarcusNoble Owned by: MarcusNoble
Priority: minor Milestone: Release 3.4
Component: Tools Keywords: AUTOREDUCTION
Cc: Blocked By:
Blocking: Tester: Lottie Greenwood

Description (last modified by MarcusNoble) (diff)

Currently the log output is pretty dire as no timestamps are printed out.

This should be resolved using the logging options available in Django: https://docs.djangoproject.com/en/dev/topics/logging/

At the very least the log level, timestamp and message need to be logged.

This will likely be a wide change in that the way the logger is loaded may need changing.

I think it would be beneficial to also improve error pages at the same time to display the exception to admins and to modify the "contact us" email link to include the time of the error to make looking up the problem in the logs much simpler.

Log files need to be rotated either daily or based on size.

For Tester:

To view the results of the improved logging log on to autoreduce.isis.cclrc.ac.uk and view '/var/log/autoreduction.log' and on reduce.isis.cclrc.ac.uk view 'C:\autoreduce\WebApp\ISIS\autoreduce_webapp\autoreduction.log'.

Change History

comment:1 Changed 6 years ago by MarcusNoble

  • Status changed from new to assigned

comment:2 Changed 6 years ago by MarcusNoble

  • Status changed from assigned to inprogress

comment:3 Changed 6 years ago by MarcusNoble

  • Description modified (diff)

comment:4 Changed 6 years ago by MarcusNoble

  • Status changed from inprogress to verify
  • Resolution set to fixed
  • Description modified (diff)

comment:5 Changed 6 years ago by Lottie Greenwood

  • Status changed from verify to verifying
  • Tester set to Lottie Greenwood

comment:6 Changed 6 years ago by Lottie Greenwood

  • Status changed from verifying to closed
Note: See TracTickets for help on using tickets.