Ticket #10805 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

Update SANSSolidAngleCorrection

Reported by: Mathieu Doucet Owned by: Mathieu Doucet
Priority: critical Milestone: Release 3.3
Component: Framework Keywords:
Cc: Blocked By:
Blocking: Tester: Peter Peterson

Description

EQSANS instrument scientists would like to update SANSSolidAngleCorrection. They provided patch. Details to be filled in later.

Change History

comment:1 Changed 6 years ago by Nick Draper

  • Status changed from new to assigned
  • Milestone changed from Release 3.3 to Release 3.4

Let me know if you think this is really vital enough to break the code freeze on R3.3

comment:2 Changed 6 years ago by Doucet, Mathieu

  • Status changed from assigned to inprogress

Re #10805 Modify solid angle correction for tubes

Changeset: 00d2f42abc3a36c10b90f1c9b2fd4b3cbc748364

comment:3 Changed 6 years ago by Mathieu Doucet

Yeah, the instrument folks would like to have it sooner than later. It's a handful of lines in one file so I'd like to put it in R3.3. Working on it now.

comment:4 Changed 6 years ago by Mathieu Doucet

  • Milestone changed from Release 3.4 to Release 3.3

comment:5 Changed 6 years ago by Mathieu Doucet

  • Status changed from inprogress to verify
  • Resolution set to fixed

comment:6 Changed 6 years ago by Pete Peterson

Merge pull request #109 from mantidproject/sans_solid_angle_update

Re #10805 Modify solid angle correction for tubes

Changeset: 72b55b22fe48bb3038bbdf2b7343516ee3667333

comment:7 Changed 6 years ago by Peter Peterson

  • Status changed from verify to verifying
  • Tester set to Peter Peterson

comment:8 Changed 6 years ago by Peter Peterson

  • Status changed from verifying to closed

trac hook was broken. This is in master.

comment:9 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​11647

Note: See TracTickets for help on using tickets.