Ticket #10827 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

BASISReduction_311 breaks naming conventions system test

Reported by: Martyn Gigg Owned by: Peter Peterson
Priority: blocker Milestone: Release 3.3
Component: Framework Keywords:
Cc: Blocked By:
Blocking: Tester: Martyn Gigg

Description

The algorithm name is not allowed to contain an underscore: ​http://builds.mantidproject.org/job/develop_systemtests_rhel6/lastCompletedBuild/testReport/SystemTests/CodeConventions/Algorithms/

Change History

comment:1 Changed 6 years ago by Martyn Gigg

  • Status changed from new to assigned

comment:2 Changed 6 years ago by Pete Peterson

  • Status changed from assigned to inprogress

Re #10827. Renaming file to follow coding conventions.

Changeset: f640bdcadd6a5bb48789b9802123b57ae4a4aa68

comment:3 Changed 6 years ago by Pete Peterson

Refs #10827. Finished renaming BASIS algorithm.

Changeset: cf979751681dcd079bcd51de752ef4257b5e883e

comment:4 Changed 6 years ago by Peter Peterson

  • Status changed from inprogress to verify
  • Resolution set to fixed

This is on ​bugfix/10827_BASISreduction_name

To test: See that the CodeConventions.Algorithms system test runs fine.

comment:5 Changed 6 years ago by Martyn Gigg

  • Status changed from verify to verifying
  • Tester set to Martyn Gigg

comment:6 Changed 6 years ago by Martyn Gigg

I've run the CodeConventions test locally and it now passes.

comment:7 Changed 6 years ago by Martyn Gigg

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/bugfix/10827_BASISreduction_name'

Full changeset: ​591dfa3499cd432b3b9bc54c2a370e32b8ea8e38

comment:8 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​11669

Note: See TracTickets for help on using tickets.