Moun interface - curves are not displayed after fit

[Nick Draper]

Start up the muon interface, load a file, then try a fit, the data is fitted, but no fit lines appear on the graph.

[Raquel Alvarez Banos]

This bug fix also fixes the two issues reported by Stephen:

• Every time the "Data Analysis" tab is selected the graph window redraws and is moved
• The vertical dashed lines indicating fitting range are missing

These bugs only take effect when "New Plot Policy" is set to "Create New Window" in the "Settings" tab.

To test:

1. Start up the muon interface, load a file, go to "Data Analysis" tab, check that the two vertical dashed lines are shown.
2. Try a fit (right click on "Functions" -> "Add function", select any of the available functions), check that fit results are displayed in the plot
3. Go to "Settings" tab. Go back to "Data Analysis" tab, check that the graph stays the same and it has not been moved from its previous position.
4. Check that the different settings produce the expected result: load a number of muon datasets. If "Create new window" is selected, all of them should be visible in the mantid "Windows" tab. If "Use previous window" is set, only the last one should appear.

[Raquel Alvarez Banos]

Re #10842 fix muon new window policy bugs

Changeset: d5c6fdb45f16fff80923c2b5925b13295efd0d4d

[Federico M Pouzols]

I can confirm that:

• Before the fix, if in the settings of the muon analysis interface, "new plot policy" is set to "create new window" the interface misbehaves as described in the ticket. With "Use previous window" there seems to be no bug.

• After the fix, fitting works well with both "create new window" and "use previous window".

Code changes make sense. Plots were not being displayed on the correct window.

While testing this we spotted an issue in the Muon interface. This may become a not so urgent ticket for the next release:

• Open the Muon Analysis interface, switch to/from the "Data Analysis" tab. For some reason, the data display toolbar of Mantid is hidden (behavior differs between windoze and Linux, it may remain hidden or it may change on/off depending on what tab you select). This also happens when you switch to different tabs of the muon data analysis interface.

[Federico Montesino Pouzols]

Merge remote-tracking branch 'origin/bugfix/10842_muon_fit_curves_not_displayed'

Full changeset: ​92069e7dcc2a388e4eb3fb1a7e333d9285354d42

[Stuart Campbell]

This ticket has been transferred to github issue ​11684