Ticket #10937 (closed: fixed)
Vanadium over vanadium reduction does not work property
| Reported by: | Alex Buts | Owned by: | Alex Buts |
|---|---|---|---|
| Priority: | major | Milestone: | Release 3.4 |
| Component: | Framework | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | Tester: | Nick Draper |
Description
This is the ticket to fix bug in direct inelastic reduction, which have been already fixed & avoided in during refactoring (#10803 etc.)
It needed to allow comparing the results of wb run produced by old reduction with the runs, produced by the new one. And current master reduction does not work.
Change History
comment:2 Changed 6 years ago by Alex Buts
- Status changed from assigned to inprogress
Re #10937 This should fix it.
Changeset: 30074380a3ea24992f95819d99fe275516c42433
comment:3 Changed 6 years ago by Alex Buts
There is trivial fix, which should not go to develop or master as it lost relevance due to the following changes. It is here as reference and fix, may be necessary to verity vanadium integration when working with Mantid 3.3 direct inelastic reduction.
comment:4 Changed 6 years ago by Alex Buts
- Status changed from inprogress to verify
- Resolution set to fixed
comment:5 Changed 6 years ago by Federico M Pouzols
- Status changed from verify to verifying
- Tester set to Federico M Pouzols
comment:6 follow-up: ↓ 7 Changed 6 years ago by Federico M Pouzols
- Status changed from verifying to reopened
- Resolution fixed deleted
I understand that to close this ticket properly the 'resolve as' field should be set to 'invalid' or 'duplicate'?
comment:7 in reply to: ↑ 6 Changed 6 years ago by Alex Buts
Replying to Federico M Pouzols:
I do not know, what is correct -- it is non-standard situation. If patch release is ever be planned, one or another version of fixes will be deployed.
I am of course hope to deploy the version I am working on now, but it is possible that previous version may be decided upon. Also, the patch based on this ticket can be safely applied to Mantid 3.3 python, while my current patch needs some C++ compilation.
comment:8 Changed 6 years ago by Alex Buts
- Status changed from reopened to verify
- Resolution set to invalid
- Milestone changed from Backlog to Release 3.4
This ticket is not relevant any more, as patch release not exist and the subsequent changes contradict the changes, made in this ticket.
Vanadium over Vanadium works fine with current Direct Inelastic.
comment:9 Changed 6 years ago by Nick Draper
- Status changed from verify to verifying
- Tester changed from Federico M Pouzols to Nick Draper
comment:11 Changed 5 years ago by Nick Draper
- Resolution changed from invalid to fixed
Somehow these slipped through without a resolution. Set to Fixed.
comment:12 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 11776
