Ticket #10952 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

SliceViewer crash

Reported by: Roman Tolchenov Owned by: Owen Arnold
Priority: major Milestone: Release 3.4
Component: GUI Keywords:
Cc: Blocked By:
Blocking: Tester: Roman Tolchenov

Description

  1. Drop two peaks workspace to the SliceViewer.
  2. Rename one of them with the new name the same as the name of the other workspace.
  3. You will see one workspace in the workspace list and still two peaks lists in SliceViewer.
  4. Delete the peaks workspace.
  5. Interact with SliceViewer. Crash.

Change History

comment:1 Changed 6 years ago by Owen Arnold

refs #10952. Observe rename events.

We need to observe and act on the special case of a rename event. The rename algorithm execution not only results in the key change in the ADS dictionary, but also the value change (workspace deep-copy). We therefore only have the old-name as a constant reference to use for find-removal. Only the PeaksWidget has this information so we go top-down to purge.

Changeset: 0eca72a2f5d1143932858c2b49176b3929cc4a5c

comment:2 Changed 6 years ago by Owen Arnold

  • Status changed from new to verify
  • Resolution set to fixed

This is being verified as ​pull request #139.

comment:3 Changed 6 years ago by Owen Arnold

refs #10952. Test update

No peaks presenter to zoom in on. Renaming the workspace results in that workspace being removed from the PeaksViewer (correct behaviour now). So the PeaksPresenter obtained previously is None.

Changeset: 04add5e84b35260c850a1ee9a1238d0ea7b8b960

comment:4 Changed 6 years ago by Roman Tolchenov

  • Status changed from verify to verifying
  • Tester set to Roman Tolchenov

comment:5 Changed 6 years ago by Roman Tolchenov

  • Status changed from verifying to closed

Merge pull request #139 from mantidproject/feature/10952_rename_crash

PeaksViewer crash

Full changeset: ​ca7b135659849dcb4a44217bc7ae963dcfca27aa

comment:6 Changed 6 years ago by Nick Draper

  • Milestone changed from Backlog to Release 3.4

moved to r 3.4 as tickets are closed

comment:7 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​11791

Note: See TracTickets for help on using tickets.