Context Navigation

← Previous Ticket
Next Ticket →

Ticket #11028 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

Add widget to select frequency units in RRFMuon algorithm

Reported by:	Raquel Alvarez Banos	Owned by:	Raquel Alvarez Banos
Priority:	major	Milestone:	Release 3.4
Component:	Muon	Keywords:
Cc:		Blocked By:
Blocking:		Tester:	Harry Jeffery

Description

Add a new widget in RRFMuon algorithm's dialog so that users can choose frequency units.

Change History

comment:1 Changed 6 years ago by Raquel Alvarez Banos

Status changed from new to assigned

comment:2 Changed 6 years ago by Raquel Alvarez Banos

Status changed from assigned to inprogress
Summary changed from Add widget to select frecuency units in RRFMuon algorithm to Add widget to select frequency units in RRFMuon algorithm

comment:3 Changed 6 years ago by Raquel Alvarez Banos

Re #11028 Including frequency widget and updating code

Changeset: 5b40fb651edd11434af3d21d4f77aaaf70873209

comment:4 Changed 6 years ago by Raquel Alvarez Banos

Re #11028 Updating widget description

Changeset: be5e56cf9186135c569e2c3d9ec23ee6ba9fc271

comment:5 Changed 6 years ago by Raquel Alvarez Banos

Re #11028 Removing couts

Changeset: 02dfc8e06e034d336030e5794e107b7cd2c7a1f1

comment:6 Changed 6 years ago by Raquel Alvarez Banos

Re #11028 Adding test to check different frequency units

Changeset: b487264136f51b667ba183da927bc452bc5bf166

comment:7 Changed 6 years ago by Raquel Alvarez Banos

Re #11028 Updating algorithm s summary

Changeset: 527207093b9a5d5ce59c18932acce793fb42a4be

comment:8 Changed 6 years ago by Raquel Alvarez Banos

Re #11028 Updating documentation

Changeset: dc2b55f125003b745e7890495551af77d594a117

comment:9 Changed 6 years ago by Raquel Alvarez Banos

Priority changed from minor to major

comment:10 Changed 6 years ago by Raquel

Status changed from inprogress to verify
Resolution set to fixed

This is being verified as pull request #201.

comment:11 Changed 6 years ago by Raquel

Jenkins, retest this please

comment:12 Changed 6 years ago by Harry Jeffery

Status changed from verify to verifying
Tester set to Harry Jeffery

comment:13 Changed 6 years ago by Harry Jeffery

Looks good, there's just a couple of things I don't understand.

[Reference 1](https://github.com/mantidproject/mantid/pull/201/files#diff-03fe806bd04bebf981748fd2817b6d5dR154) The TS_ASSERT_DELTA makes sense, but if we want to be sure they're the same value, ignoring precision errors, why have TS_ASSERT_DIFFERS? Wouldn't them having the same exact value just be a happy coincidence, not an error?
[Reference 2](https://github.com/mantidproject/mantid/pull/201/files#diff-eee76f331e17a916b7829be300243cb1R116) This may be my ignorance showing (I'm just a lowly computer scientist after all :wink:), but a comment explaining what exactly the 135.538.. value is and where it comes from would probably be useful for future reference.

comment:14 Changed 6 years ago by Raquel

You are right about Reference 2, I should have added a comment. That number corresponds to the muon gyromagnetic ratio (in MHz/T), I will update the code accordingly. Regarding Reference 1, what I want to check is that both results are similar, but they should not be exactly the same. If they were, something would be wrong. I will also add some explanation. Thanks for your comments :)