Ticket #11075 (closed: wontfix)

Opened 6 years ago

Last modified 5 years ago

Trim down tool names in new plotting interface

Reported by: Martyn Gigg Owned by: Martyn Gigg
Priority: major Milestone: Release 3.4
Component: Python Keywords:
Cc: owen.arnold@… Blocked By:
Blocking: Tester: Dan Nixon

Description (last modified by Martyn Gigg) (diff)

The new Python cli for plotting is nice and compact but I think a couple of the tool names could use a little bit of a trim down, e.g.

plot(ws, tool="plot_spectrum")

feels like we are unnecessarily repeating the plot word.

The current tool names are

  • plot_spectrum
  • plot_bin
  • plot_md

How about just:

  • spectrum
  • bin
  • md

?

This then fits better with the 'vsi' option for the new VSI plotting.

I am, of course, open to suggestions too.

Change History

comment:1 Changed 6 years ago by Martyn Gigg

  • Description modified (diff)

comment:2 Changed 6 years ago by Federico M Pouzols

Humm, actually there will be a new tool coming hopefully soon: 'vsi'. The change makes sense to me.

comment:3 Changed 6 years ago by Owen Arnold

I think we should try to keep consistent with whatever matplotlib does.

I would say this however for prefixing things with plot. Not everyone is going to intuitively know what these new plot commands are going to be. For example, spectrum could be known as histogram, eventlist .... etc. At least prefixing things with plot, the autocompletion in say ipython, will show you what options there are for variations of plot.

comment:4 Changed 6 years ago by Federico M Pouzols

The autocompletion point is a good one. That would imply tool='plot_vsi' for the new tool.

I don't remember anything similar from matplotlib. In that respect 'vsi' would be fine and 'plot_vsi' too, they use lowercase and _ between words, that's all we can borrow I think.

comment:5 Changed 6 years ago by Martyn Gigg

  • Status changed from new to verify
  • Owner changed from Federico M Pouzols to Martyn Gigg
  • Resolution set to wontfix

Yes, the tool argument is our invention, correct?

Self-consistency is definitely the key here so keeping what we have would imply 'plot_vsi' would be the new tool name/function name. I take the point about autocompletion and keeping the vocabulary the same so we can keep that but we should update the new VSI cli doc with the tool 'plot_vsi' name.

comment:6 Changed 6 years ago by Federico M Pouzols

Yes, I don't thing there's anything directly comparable in matplotlib.

Ok, so let's call it 'plot_vsi'. This way the possible values of plot= are the names of the alternative plot_XXX commands.

comment:7 Changed 6 years ago by Dan Nixon

  • Status changed from verify to verifying
  • Tester set to Dan Nixon

comment:8 Changed 6 years ago by Dan Nixon

  • Status changed from verifying to closed

comment:9 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 11914

Note: See TracTickets for help on using tickets.