Ticket #11288 (closed: fixed)
Refactor ConvertSpiceDataToReadlSpace
| Reported by: | Wenduo Zhou | Owned by: | Wenduo Zhou |
|---|---|---|---|
| Priority: | major | Milestone: | Release 3.4 |
| Component: | Diffraction | Keywords: | |
| Cc: | petersonpf@…, saviciat@… | Blocked By: | |
| Blocking: | Tester: | VickieLynch |
Description (last modified by Wenduo Zhou) (diff)
The present approach to create MDEventWorkspace in this algorithm is to write a temporary MD file from a set of MatrixWorkspaces and load the file by calling 'ImportMDEventWorkspace'. This approach is not efficient especially when the file is huge.
Write a new method to create MDEventWorkspace and add MDEvents inside Mantid.
ConvertSpiceDataToRealSpace creates an MD workspace with Y min and max limits both 0
Change History
comment:2 Changed 6 years ago by Wenduo Zhou
- Status changed from new to inprogress
Started to refactor the MD codes. Refs #11288.
Changeset: ee70995b7c5e347cef42c94a00bd51b9cebd66c0
comment:3 Changed 6 years ago by Wenduo Zhou
Replaced C++ algorithms other than child algorithm call. Refs #11288.
Changeset: 278f83d3c15e140704ac63f0ddb80afd0daf3781
comment:4 Changed 6 years ago by Wenduo Zhou
- Status changed from inprogress to verify
- Resolution set to fixed
This is being verified as pull request #474.
comment:5 Changed 6 years ago by Wenduo Zhou
- Status changed from verify to reopened
- Resolution fixed deleted
comment:6 Changed 6 years ago by Wenduo Zhou
- Status changed from reopened to inprogress
Refs #11288. Fixed unit test due to new feature.
Changeset: c6e0b3f683e50de2ea64d338f996b3681a90a9bf
comment:7 Changed 6 years ago by Wenduo Zhou
Fixed the issue of binning of MDWorkspace. Refs #11288.
Changeset: 6e32e860648ea81a973fa1bde7edb174cd0674ac
comment:9 Changed 6 years ago by Wenduo Zhou
Tried to fix warnings. Refs #11288.
Changeset: 902f9b3bffb0c1791dfb9ccc7535c2d472828172
comment:10 Changed 6 years ago by Wenduo Zhou
Tried to fix ubuntu warnings. Refs #11288.
Changeset: a8f83af272dcb8a3a4fd3c1708a3c30ff529dcb5
comment:11 Changed 6 years ago by Wenduo Zhou
Fixed the last warning. Refs #11288.
Changeset: 01c5159a00608d0462d525ec806516130f7fa32b
comment:12 Changed 6 years ago by Wenduo Zhou
retest this please.
comment:13 Changed 6 years ago by Wenduo Zhou
retest this please.
comment:14 Changed 6 years ago by Wenduo Zhou
Cleaned logging. Refs #11288.
Changeset: d6d28ad5ba819c24de1d8c038adec82a90e6e6a6
comment:15 Changed 6 years ago by Wenduo Zhou
Merged with master and resolve conflicts. Refs #11288.
Changeset: c4141a127f5a269bace3f438c70517cc7730b68c
comment:16 Changed 6 years ago by Wenduo Zhou
For tester:
The purpose of this issue is to create MDEventWorkspaces by calling C++ methods directly instead of calling Mantid algorithm to generate MD files and then import them. For this, you can check code and unit tests.
Another issue solved is the binning on some direction if all the signals have the same position on this direction. For example, all signals of HFIR HB2A have the same y-value. Previously, the range of Y values of the output MDEventWorkspace is from 0 to 0. Now it is not.
comment:17 Changed 6 years ago by Wenduo Zhou
- Status changed from inprogress to verify
- Resolution set to fixed
comment:19 Changed 6 years ago by VickieLynch
- Status changed from verifying to closed
- Tester set to VickieLynch
Merge pull request #474 from mantidproject/feature/11288_refactor_convertspice
Refactor ConvertSpiceDataToRealWorkspace
Full changeset: 2eb7b1c6278d7c626c9d4296ef15e265e2eb9780
comment:21 Changed 5 years ago by Andrei Savici
- Component changed from Direct Inelastic to Diffraction
comment:22 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 12127
