Ticket #11350 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

Avoid loading experiment info from accumulated MD file

Reported by: Martyn Gigg Owned by: Martyn Gigg
Priority: critical Milestone: Release 3.4
Component: Direct Inelastic Keywords:
Cc: Blocked By: #11359
Blocking: Tester: Anders-Markvardsen

Description

#11111 used the FileBackedExperimentInfo in LoadMD. It seems that there are some cases in ConvertToMD that cause the experiment information to be loaded unnecessarily.

These should be eliminated.

Change History

comment:1 Changed 6 years ago by Martyn Gigg

  • Status changed from new to inprogress

Fix a doxygen warning.

Refs #11350

Changeset: cd3a37c8011164927efb0bac2376dfa0ac5661fd

comment:2 Changed 6 years ago by Martyn Gigg

Don't populate a file-backed experiment info on cloning.

Refs #11350

Changeset: 7c670e0734ce2a58890b934280afe100426074e4

comment:3 Changed 6 years ago by Martyn Gigg

Only copy meta data to most current experiment info

If the workspace contains other experiments it is assumed that when they were converted they had their meta data copied at that point. Refs #11350

Changeset: 2c2672d8e4b4a0b43fc4872c6d6b68cf394de051

comment:4 Changed 6 years ago by Martyn Gigg

Remove unused log entry.

Refs #11350

Changeset: 825f650e152afb243ab7e9233a640a393e999bae

comment:5 Changed 6 years ago by Martyn Gigg

Use last experiment info to store coordinate system

This will be the one in memory when using ConvertToMD to accumulate files. Refs #11350

Changeset: 0984ed0b96ace5de867345e33be097f3b780c2d6

comment:6 Changed 6 years ago by Martyn Gigg

Clang format ConvertToMD.

Refs #11350

Changeset: 497b59d286e58b5c4d24237ec4a67408b42987cf

comment:7 Changed 6 years ago by Martyn Gigg

  • Status changed from inprogress to verify
  • Resolution set to fixed

This is being verified as pull request #388.

comment:8 Changed 6 years ago by Martyn Gigg

  • Blocked By 11359 added

comment:9 Changed 6 years ago by Martyn Gigg

Fix VatesAPI test that alters the number of ExperimentInfo objects

Refs #11350

Changeset: 41d3b6d60f5023dffb4ef1cdbe278d91613501fd

comment:10 Changed 6 years ago by Martyn Gigg

Merge branch '11359_md_coordinate_as_own_field' into 11350_converttomd_no_expt_info_loading

Conflicts:

Code/Mantid/Framework/MDEvents/src/MDEventWorkspace.cpp

Refs #11350

Changeset: bacb8b42e87bb737fc99ad844b9011fd729f98db

comment:11 Changed 6 years ago by Martyn Gigg

Fix a doxygen warning.

Refs #11350

Changeset: cd3a37c8011164927efb0bac2376dfa0ac5661fd

comment:12 Changed 6 years ago by Martyn Gigg

Don't populate a file-backed experiment info on cloning.

Refs #11350

Changeset: 7c670e0734ce2a58890b934280afe100426074e4

comment:13 Changed 6 years ago by Martyn Gigg

Only copy meta data to most current experiment info

If the workspace contains other experiments it is assumed that when they were converted they had their meta data copied at that point. Refs #11350

Changeset: 2c2672d8e4b4a0b43fc4872c6d6b68cf394de051

comment:14 Changed 6 years ago by Martyn Gigg

Remove unused log entry.

Refs #11350

Changeset: 825f650e152afb243ab7e9233a640a393e999bae

comment:15 Changed 6 years ago by Martyn Gigg

Use last experiment info to store coordinate system

This will be the one in memory when using ConvertToMD to accumulate files. Refs #11350

Changeset: 0984ed0b96ace5de867345e33be097f3b780c2d6

comment:16 Changed 6 years ago by Martyn Gigg

Clang format ConvertToMD.

Refs #11350

Changeset: 497b59d286e58b5c4d24237ec4a67408b42987cf

comment:17 Changed 6 years ago by Martyn Gigg

Fix VatesAPI test that alters the number of ExperimentInfo objects

Refs #11350

Changeset: 41d3b6d60f5023dffb4ef1cdbe278d91613501fd

comment:18 Changed 6 years ago by Martyn Gigg

Merge branch '11359_md_coordinate_as_own_field' into 11350_converttomd_no_expt_info_loading

Conflicts:

Code/Mantid/Framework/MDEvents/src/MDEventWorkspace.cpp

Refs #11350

Changeset: bacb8b42e87bb737fc99ad844b9011fd729f98db

comment:19 Changed 6 years ago by Anders-Markvardsen

  • Status changed from verify to closed
  • Tester set to Anders-Markvardsen

Merge pull request #388 from mantidproject/11350_converttomd_no_expt_info_loading

Avoid loading experiment info from accumulated MD file

Full changeset: b642131b5652484081f462f07a46da3351919006

comment:20 Changed 5 years ago by Nick Draper

  • Component changed from Framework to Direct Inelastic

comment:21 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 12189

Note: See TracTickets for help on using tickets.