Ticket #11412 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

Remove to_string in MSDFit.cpp

Reported by: Dan Nixon Owned by: Dan Nixon
Priority: major Milestone: Release 3.4
Component: Indirect Inelastic Keywords:
Cc: Blocked By:
Blocking: Tester: Federico Montesino Pouzols

Description

Replace this with a pre C++11 alternative: 

std::string searchString = "_" + std::to_string(static_cast<long long int>(specNo)) + "_Workspace";

Change History

comment:1 Changed 6 years ago by Dan Nixon

  • Status changed from new to assigned

comment:2 Changed 6 years ago by Dan Nixon

  • Status changed from assigned to inprogress

Use stringstream instead of to_string

Refs #11412

Changeset: 2b095618cb27e04af2b06e300231d3e96ed0b28d

comment:3 Changed 6 years ago by Dan Nixon

  • Status changed from inprogress to verify
  • Resolution set to fixed

This is being verified as ​pull request #436.

comment:4 Changed 6 years ago by Federico Montesino Pouzols

Everything seems fine. I played a bit with the example file in MSDFit and it behaved well.

comment:5 Changed 6 years ago by Federico Montesino Pouzols

  • Status changed from verify to verifying
  • Tester set to Federico Montesino Pouzols

comment:6 Changed 6 years ago by Dan Nixon

Use stringstream instead of to_string

Refs #11412

Changeset: 2b095618cb27e04af2b06e300231d3e96ed0b28d

comment:7 Changed 6 years ago by Federico Montesino Pouzols

  • Status changed from verifying to closed

Merge pull request #436 from mantidproject/11412_remove_to_string_in_msdfit

Remove to_string in MSDFit.cpp

Full changeset: ​ac8dd1476d1097bf6b2895e343a30ad69092f082

comment:8 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​12251

Note: See TracTickets for help on using tickets.