Ticket #11514 (closed: fixed)

Opened 5 years ago

Last modified 5 years ago

Optimise out `openPath` call in LoadNexusProcessed

Reported by: Harry Jeffery Owned by: Harry Jeffery
Priority: major Milestone: Release 3.4
Component: Framework Keywords:
Cc: Blocked By:
Blocking: Tester: Owen Arnold

Description

Calling NeXuS::File::openPath is *very* expensive. We should avoid using it in performance critical sections. This ticket is for its removal in LoadNexusProcessed's multiperiod loading routine.

This builds upon the optimisations done in #11505 as part of #11483

Change History

comment:1 Changed 5 years ago by Harry Jeffery

  • Status changed from new to inprogress

comment:2 Changed 5 years ago by Harry Jeffery

Refs #11514 Optimise out openPath in LoadNexusProcessed

Changeset: 8a6cdf986447150fdb6d6788cc1546b01d6625cd

comment:3 Changed 5 years ago by Harry Jeffery

  • Status changed from inprogress to verify
  • Resolution set to fixed

This is being verified as ​pull request #562.

comment:4 Changed 5 years ago by Owen Arnold

  • Status changed from verify to verifying
  • Tester set to Owen Arnold

comment:5 Changed 5 years ago by Owen Arnold

  • Status changed from verifying to closed

Merge pull request #562 from mantidproject/11514_optimise_out_openpath_in_loadnexusprocessed

Optimise out openPath in LoadNexusProcessed

Full changeset: ​972d0760ccd63ed49cf42d0327063145d881b240

comment:6 Changed 5 years ago by Owen Arnold

About 12 times faster now on my machine.

comment:7 Changed 5 years ago by Nick Draper

Somehow these slipped through without a resolution. Set to Fixed.

comment:8 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​12352

Note: See TracTickets for help on using tickets.