Ticket #11515 (closed: fixed)

Opened 5 years ago

Last modified 5 years ago

Resolve dead code coverity issues

Reported by: Harry Jeffery Owned by: Harry Jeffery
Priority: minor Milestone: Release 3.4
Component: Framework Keywords:
Cc: Blocked By:
Blocking: Tester: Andrei Savici

Description (last modified by Harry Jeffery) (diff)

There's ~40 coverity issues concerned with dead code. These can be cleaned up.

Change History

comment:1 Changed 5 years ago by Harry Jeffery

  • Description modified (diff)

comment:2 Changed 5 years ago by Harry Jeffery

  • Status changed from new to inprogress

comment:3 Changed 5 years ago by Harry Jeffery

Refs #11515 Remove dead return in DynamicKuboToyabe

Changeset: 271bcfa306993aeabd4a447ae7d9281d7b85dfd1

comment:4 Changed 5 years ago by Harry Jeffery

Refs #11515 Fix up indentation in DynamicKuboToyabe

Changeset: cf3a069931245b4f33a3caf8bb41a012285688e2

comment:5 Changed 5 years ago by Harry Jeffery

Refs #11515 Remove dead returns in Unit.cpp

Changeset: da4f7fca0b43f7ed792a88350bf64618862215a9

comment:6 Changed 5 years ago by Harry Jeffery

Refs #11515 Refactor dead code in CompositePeaksPresenterVsi

Changeset: 203b8815d15183cfd591e74ee514eb22e3b81a24

comment:7 Changed 5 years ago by Harry Jeffery

Refs #11515 Fix dead code in Graph.cpp

Changeset: 9a245dbe5ab13423a6b8c643c2533027fee69cfa

comment:8 Changed 5 years ago by Harry Jeffery

Refs #11515 Fix dead code in MetaDataExtractorUtils.cpp

Changeset: df4ab572ef2e01352bd7f3b2b688a1aff8486ae0

comment:9 Changed 5 years ago by Harry Jeffery

Refs #11515 Remove dead code in GenerateEventsFilter.cpp

Changeset: b653021e9ecc467256c1c4e68e50a22262967841

comment:10 Changed 5 years ago by Harry Jeffery

Refs #11515 Remove dead function from FilterEventsByLogValuePreNexus

Changeset: 3617043161701dbd3b9292dd387846645a3eb670

comment:11 Changed 5 years ago by Harry Jeffery

Refs #11515 Fix dead code in CatalogInfo

Changeset: b5ccfc374774f1bdb5bea093f7c306370a03d0c4

comment:12 Changed 5 years ago by Harry Jeffery

Refs #11515 Fix dead code in MantidMatrix

Changeset: 2a91ace15c12ef97834e43ee48a55bcb9ba98c54

comment:13 Changed 5 years ago by Harry Jeffery

Refs #11515 Remove dead code in MaskPeaksWorkspace

Changeset: 6c5ba5c5dfd6bc51bc31bfeaab56174dec42eb44

comment:14 Changed 5 years ago by Harry Jeffery

Refs #11515 Remove dead code in RectangularDetector

Changeset: 928200c956808debd19cb1de3c8056b4b309ffab

comment:15 Changed 5 years ago by Harry Jeffery

Refs #11515 Remove dead code in Triple

Changeset: cb5c0617c0f339911cc0f7e4fd438022b6136a06

comment:16 Changed 5 years ago by Harry Jeffery

Refs #11515 Remove dead code in PropertyWithValue

Changeset: 1576da767b8d6d08eebfb41478df983912d1d015

comment:17 Changed 5 years ago by Harry Jeffery

Refs #11515 Remove dead code in ScriptRepositoryImpl

Changeset: 77b72a20cfb1b6c458cf2b5562fdd59b12d97cd2

comment:18 Changed 5 years ago by Harry Jeffery

Refs #11515 Fix dead code in InstrumentActor

Changeset: 755d612f6d3acbaf0d03049a2b04fa91e24863b8

comment:19 Changed 5 years ago by Harry Jeffery

Refs #11515 Remove dead code in QwtBarCurve

Changeset: 9818e7ca9300f12223fbb1a1910d14ddff5139ec

comment:20 Changed 5 years ago by Harry Jeffery

Refs #11515 Fix dead code in MultipleFileProperty

Changeset: dcf0f9f23ca9179abf8a610b724bb6f1dec3f15b

comment:21 Changed 5 years ago by Harry Jeffery

Refs #11515 Fix dead code in ResetNegatives

Changeset: 5acd5885276934db18324994746386ae9410809d

comment:22 Changed 5 years ago by Harry Jeffery

Refs #11515 Fix dead code in RemovePromptPulse

Changeset: ca2906a1239e4e9a15f93fcc87b8e4d31bbb7457

comment:23 Changed 5 years ago by Harry Jeffery

Refs #11515 Fix deadcode in Goniometer

Changeset: 1f52f7d709eec2ccb5e551f080475c68efcbc9a3

comment:24 Changed 5 years ago by Harry Jeffery

  • Status changed from inprogress to verify
  • Resolution set to fixed

This is being verified as ​pull request #567.

comment:25 Changed 5 years ago by Harry Jeffery

Refs #11515 Fix build on RHEL and Windows

Changeset: 6d349be583ac51cecacaf67d9a72bda378aca4d4

comment:26 Changed 5 years ago by Harry Jeffery

Revert "Refs #11515 Fix dead code in RemovePromptPulse"

This reverts commit ca2906a1239e4e9a15f93fcc87b8e4d31bbb7457.

Changeset: aaa35d9cf080a69bc202d2a8333587545934b86a

comment:27 Changed 5 years ago by Andrei Savici

  • Status changed from verify to verifying
  • Tester set to Andrei Savici

comment:28 Changed 5 years ago by Andrei Savici

Please merge master into your branch

comment:29 Changed 5 years ago by Harry Jeffery

Refs #11515 Merge branch 'master' into 11515_remove_dead_code

Changeset: d1d180e3ed6835a7e3ba73a99cf637d6702a9e2b

comment:30 Changed 5 years ago by Andrei Savici

  • Status changed from verifying to closed

Merge pull request #567 from mantidproject/11515_remove_dead_code

Checked by code review

Full changeset: ​c565130109bc0911364a660b284202dd8c8f0ee5

comment:31 Changed 5 years ago by Nick Draper

Somehow these slipped through without a resolution. Set to Fixed.

comment:32 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​12353

Note: See TracTickets for help on using tickets.