Ticket #11575 (closed: fixed)

Opened 5 years ago

Last modified 5 years ago

Support FITS files produced by Starlight cameras in LoadFITS

Reported by: Federico M Pouzols Owned by: Federico M Pouzols
Priority: major Milestone: Release 3.4
Component: Framework Keywords:
Cc: Blocked By:
Blocking: Tester: Raquel Alvarez

Description

James Lord has provided example files that LoadFITS fails to load + example code.

There are currently issues with some header values that are given as floating point numbers where LoadFITS expects/assumes integers.

Beware that these cameras produce FITS files that are OK-ish but not fully standard compliant.

As part of this ticket we might also add an option to load FITS images into "rectangular" Workspace2D, rather than using one histogram per pixel.

Change History

comment:1 Changed 5 years ago by Federico Montesino Pouzols

  • Status changed from new to inprogress

fix header int/double format issues, better err handling, re #11575

Changeset: 5bd112aba7c5f5c266313d6aa85aef3bde8b8175

comment:2 Changed 5 years ago by Federico Montesino Pouzols

more verbose exception messages, re #11575

Changeset: 81bfcfa3c89f517169c9b8deb199135d3df92e52

comment:3 Changed 5 years ago by Federico Montesino Pouzols

load 'rectangular', start new props: rebin, scale, filter, re #11575

Changeset: 46b7d2a51bbbbcd18cab6573825aea19231677ef

comment:4 Changed 5 years ago by Federico Montesino Pouzols

add tomography category, re #11575

Changeset: c89706a8c9b479409241814be1d5473b69426102

comment:5 Changed 5 years ago by Federico Montesino Pouzols

tidy up and implement props BinSize and FilterNoiseLevel, re #11575

Changeset: 0f972007117af582c9259ea6e52665483d63f3e9

comment:6 Changed 5 years ago by Federico Montesino Pouzols

added unit tests for new props, re #11575

Changeset: 3bd8e1d7028d3d5f2d7e8cf748f8e16a77d2477f

comment:7 Changed 5 years ago by Federico Montesino Pouzols

added text and doc test example for LoadAsRectImg, re #11575

Changeset: 1796423ea7afcaec85da036bb81589ed2c3f811a

comment:8 Changed 5 years ago by Federico Montesino Pouzols

Polish doxygen tags, re #11575

Changeset: 1fd4d938b9798efda37fdd857956eb88d9a9fb4e

comment:9 Changed 5 years ago by Federico Montesino Pouzols

  • Status changed from inprogress to verify
  • Resolution set to fixed

This is being verified as ​pull request #653.

comment:10 Changed 5 years ago by Federico Montesino Pouzols

fix case and typos in doxygen tags, re #11575

Changeset: 0d560f2d1ea39104ded50798a086b47e1223e4d0

comment:11 Changed 5 years ago by Raquel Alvarez

  • Status changed from verify to verifying
  • Tester set to Raquel Alvarez

comment:12 Changed 5 years ago by Raquel Alvarez

I have noticed that static member variables do not follow naming conventions, could they be renamed here? Other than that, the changes look good and the algorithm is well documented. Ready to merge.

comment:13 Changed 5 years ago by Federico Montesino Pouzols

use proper g_ prefix for static data members, re #11575

Changeset: a3e070876309e321d209767a82f50bc71a10df0c

comment:14 Changed 5 years ago by Federico Montesino Pouzols

Good that you caught it. I had been carried over from older branches for a while now. It's fixed in the last commit.

And yes, the "TODO" comment is as far as we can get for now. We still have to sort out how to interpret those workspaces with one histogram per pixel.

comment:15 Changed 5 years ago by Raquel Alvarez

  • Status changed from verifying to closed

Merge pull request #653 from mantidproject/11575_LoadFITS_support_FITS_from_Starlight_cameras

LoadFITS: support images from Starlight cameras

Full changeset: ​7e8b849d3e6ebffb73ab840ad74c6e5152eefa64

comment:16 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​12413

Note: See TracTickets for help on using tickets.