Ticket #11757 (closed: fixed)

Opened 5 years ago

Last modified 5 years ago

ParaView plugins need ability to show different normalization

Reported by: Owen Arnold Owned by: Owen Arnold
Priority: critical Milestone: Release 3.5
Component: Framework Keywords: vates
Cc: Blocked By:
Blocking: #11347 Tester: Federico Montesino Pouzols

Description

Currently ALL datasets normalize hard-coded by volume. Until this is fixed we cannot have a top-level menu to pre-set the normalisation option (like the slice viewer does). Ultimately we want the sliceviewer and vsi to work the same in this regard.

  • Allow the user to change the normalization of EACH source
  • Allow and default to an auto-select mechanism

Change History

comment:1 Changed 5 years ago by Owen Arnold

  • Status changed from new to inprogress

refs #11757. vtkHexFactory done

Changeset: ee1081597907ca3f218997e8f29ffb99610df29b

comment:2 Changed 5 years ago by Owen Arnold

refs #11757. Apply for vtkMDQuadFactory

Changeset: 4bc3d60d348b3db7adf354712b7d6e182cfcad86

comment:3 Changed 5 years ago by Owen Arnold

refs #11757. Apply for vtkMDLineFactory

Changeset: 595629516cb2bb26ed1b9c9e30a104cdd6a9300e

comment:4 Changed 5 years ago by Owen Arnold

refs #11757. Apply for vtkMD0Factory

Changeset: 229e6f93ef54344e97728289d194a8477ac3d9e5

comment:5 Changed 5 years ago by Owen Arnold

refs #11757. Update MDEW reader

Changeset: 4d976486deae2fcf9ba688e9cebf9b2a8c68d33f

comment:6 Changed 5 years ago by Owen Arnold

refs #11757. Remove Dead Readers!

Readers processing Event Workspaces (not MDEventWorkspaces) have been removed, because the conversion step requires too many parameters to get this right automatically.

Readers processing SQW files have been removed, because this isn't really using Mantid. Anyway, if someone wanted this functionality, they could load the SQW file into mantid and save it out as a nexus file via SaveMD.

This reduces code overhead and maintance of features that shouldn't or don't get used.

Changeset: b25404c3bb8c1805487ebf8e8de7e35ace6ecd46

comment:7 Changed 5 years ago by Owen Arnold

refs #11757. Normalization options for histogram ws

Changeset: 5a2d16c832d66bfff5d67ef7c4c13470087d958f

comment:8 Changed 5 years ago by Owen Arnold

  • Status changed from inprogress to verify
  • Resolution set to fixed

This is being verified as pull request #775.

comment:9 Changed 5 years ago by Anton Piccardo-Selg

  • Status changed from verify to verifying
  • Tester set to Anton Piccardo-Selg

comment:10 Changed 5 years ago by Anton Piccardo-Selg

Refs #11757 Fix how scale plugin updates metadata

Changeset: f60dc10a45b9c08254780c5be8c0c0ecc661a416

comment:11 Changed 5 years ago by Owen Arnold

@picatess These changes work for me

comment:12 Changed 5 years ago by Federico Montesino Pouzols

  • Tester changed from Anton Piccardo-Selg to Federico Montesino Pouzols

comment:13 Changed 5 years ago by Owen Arnold

  • Status changed from verifying to verify
  • Tester Federico Montesino Pouzols deleted

comment:14 Changed 5 years ago by Federico Montesino Pouzols

I'm testing this now. There were a couple of conflicts which are simple to sort out: Code/Mantid/Vates/ParaviewPlugins/ParaViewReaders/SQWEventReader/CMakeLists.txt and Code/Mantid/Vates/ParaviewPlugins/ParaViewReaders/EventNexusReader/CMakeLists.txt. Both have been deleted here and in parallel were modified in master (the LINK_PRIVATE maintenance ticket I'd guess). If that's fine by you I'll fix the conflict by merging manually unless I find any unexpected issue when I play a bit with this branch.

comment:15 Changed 5 years ago by Federico Montesino Pouzols

Merge branch 'master' into 11757_vsi_normalization_options

Conflicts:

Code/Mantid/Vates/ParaviewPlugins/ParaViewReaders/EventNexusReader/CMakeLists.txt Code/Mantid/Vates/ParaviewPlugins/ParaViewReaders/SQWEventReader/CMakeLists.txt

Sorting out conflict, these two CMakeLists.txt really go away, re #11757

Changeset: fb51b9f88b53826dd72a307f7e5e7511829c2602

comment:16 Changed 5 years ago by Federico Montesino Pouzols

  • Status changed from verify to closed
  • Tester set to Federico Montesino Pouzols

Merge branch '11757_vsi_normalization_options'

Full changeset: 8c586fed63d6ee5ed9f1a340829f45285e4f2baf

comment:17 Changed 5 years ago by Federico Montesino Pouzols

All looks perfectly fine, I tested it locally and played a bit with the VSI just in case. Everything worked well. The only thing that caught my eye is that in several places in vtkMDHexFactory::doCreate() something like this is done, with VERBOSE==true: ` if (VERBOSE)

std::cout << tim << " to create the necessary points." << std::endl;

` Are these verbose messages meant to be there, or maybe they're leftovers that could be disabled/removed?

comment:18 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 12595

Note: See TracTickets for help on using tickets.