Ticket #11829 (closed: fixed)

Opened 5 years ago

Last modified 5 years ago

Fix as many as possible "uninitialized variable" coverity issues in Framework component

Reported by: Federico M Pouzols Owned by: Federico M Pouzols
Priority: major Milestone: Release 3.5
Component: Framework Keywords: Maintenance
Cc: Blocked By:
Blocking: #11791 Tester: Raquel Alvarez

Description (last modified by Federico M Pouzols) (diff)

A bunch of them are already assigned and included in other tickets. Approximately 126 are still orphan/unassigned. Take more issues from the pool of unassigned ones and try to fix them. If you feel brave fix them all. Many if not most of these issues are simple to fix just by initializing member variables in the class constructors.

Change History

comment:1 Changed 5 years ago by Federico M Pouzols

  • Description modified (diff)

comment:2 Changed 5 years ago by Federico M Pouzols

  • Owner set to Federico M Pouzols
  • Status changed from new to assigned

comment:3 Changed 5 years ago by Federico Montesino Pouzols

  • Status changed from assigned to inprogress

fix uninit coverity issue 1075395, re #11829

Changeset: 3aa798fee1408a7fb4c0810cb3f9ab5ea0b28e93

comment:4 Changed 5 years ago by Federico Montesino Pouzols

fix uninit coverity issue 1075316, re #11829

Changeset: 833d7d44b1b3eb8ac4657dee70a3ce8eda5aa12c

comment:5 Changed 5 years ago by Federico Montesino Pouzols

fix uninit coverity issue 1075317, re #11829

Changeset: 434e978b8f0850d7e0b81ad0929af8a75f378225

comment:6 Changed 5 years ago by Federico Montesino Pouzols

fix uninit coverity issue 1075318, re #11829

Changeset: f239ed0856fe362a3bab8317b65ac640321f42cf

comment:7 Changed 5 years ago by Federico Montesino Pouzols

fix uninit coverity issue 1075413, re #11829

Changeset: 10ee4ceda6fc21b8762c7fde6200111d9b4479a9

comment:8 Changed 5 years ago by Federico Montesino Pouzols

fix uninit coverity issue 1075336, re #11829

Changeset: 49cfeb2a9301b7fda9cb7c69bc2b4e81b7cae42b

comment:9 Changed 5 years ago by Federico Montesino Pouzols

fix uninit coverity issue in MD algs, (1075339...1075352), re #11829

Changeset: be7d5ee2e0f72e982ed82110a9ab54e9783eaad6

comment:10 Changed 5 years ago by Federico Montesino Pouzols

fix uninit coverity issues in ADARA, 1075353-1075356, re #11829

Changeset: 6efe91069982cf1c3c2de716a366ffe5494d653f

comment:11 Changed 5 years ago by Federico Montesino Pouzols

fix uninit coverity issues in Kernel::Unit, 1075357-1075365, re #11829

Changeset: 1a8942be4ac7751275f665e880963e7c38a6ec29

comment:12 Changed 5 years ago by Federico Montesino Pouzols

fix coverity uninits in GluGeometryHandler, 1075370-1075372, re #11829

Changeset: 3a2222a8370e4eec13f6c55ad4f2f0749bef097b

comment:13 Changed 5 years ago by Federico Montesino Pouzols

fix coverity uninits BitmapGeometryHandler, 1075373-1075374, re #11829

Changeset: ea7d1d19f1342eb957a8ac4ef9218551cd2b2401

comment:14 Changed 5 years ago by Federico M Pouzols

  • Description modified (diff)

comment:15 Changed 5 years ago by Federico Montesino Pouzols

fix coverity uninits RectangularDet , 1075376-1075378, re #11829

Changeset: da2ffccc5395cbac5787dd487f89e020bce7ca5c

comment:16 Changed 5 years ago by Federico Montesino Pouzols

coverity uninits - Geometry, DataObjects, 1075379-1075386, re #11829

Changeset: 03e041f7a9937f994cee285cd299cf9297b63914

comment:17 Changed 5 years ago by Federico Montesino Pouzols

coverity uninits DataHandling, CurveFitting 1075390-1075438, re #11829

Changeset: 3be0d54be1ae19dbf8041e7b644746808fc9d6a0

comment:18 Changed 5 years ago by Federico Montesino Pouzols

some coverity uninits in algorithms, 1075439...1075453, re #11829

Changeset: 08f6df056c42f3bbfa9f99b7a7f37a081f757f63

comment:19 Changed 5 years ago by Federico Montesino Pouzols

finishing coverity uninits in algorithms, 1075454...1075488, re #11829

Changeset: d0ea5f90d309886d23c2d1e08dde6af4e61942cd

comment:20 Changed 5 years ago by Federico Montesino Pouzols

finishing coverity uninits in algorithms, 1075454...1075488, re #11829

Changeset: b897353e3ca8b5236f3336df3cd8194bbff7393c

comment:21 Changed 5 years ago by Federico Montesino Pouzols

fix coverity uninits issues in API, 1075490...1075499, re #11829

Changeset: 20865daf729fcee2cccfa02b60e6d23a7007fefa

comment:22 Changed 5 years ago by Federico Montesino Pouzols

coverity uninits issues in crystal, etc, 1075493...1075849, re #11829

Changeset: f397c929271577755b023c12229b3d06195f9bb0

comment:23 Changed 5 years ago by Federico Montesino Pouzols

newer coverity issues in framework, up to 1127165, re #11829

Changeset: 2fa2270c230f84e1f4d93f492a29d5f2223c6ced

comment:24 Changed 5 years ago by Federico Montesino Pouzols

coverity uninit issues framework, batch 1127166 to 1297912, re #11829

Changeset: 1015c9a74ef441ac175ef7589b9961b05e66e238

comment:25 Changed 5 years ago by Federico Montesino Pouzols

  • Status changed from inprogress to verify
  • Resolution set to fixed

This is being verified as ​pull request #807.

comment:26 Changed 5 years ago by Federico Montesino Pouzols

fix doxygen, cppcheck suppress and win / rhel6 issues, re #11829

Changeset: 54e0917e2063357da00df93207abb5fa1d2974ee

comment:27 Changed 5 years ago by Federico Montesino Pouzols

fix unused var warning from llvm, re #11829

Changeset: d89065a57ac2c6d7dff033ab246fee6f996cb084

comment:28 Changed 5 years ago by Federico Montesino Pouzols

DownloadFilteTest strikes again. I think this is fine, it had got the green light on win7 before bug there was a warning on osx. Now all the checks passed except win7 because of the unrelated DownloadFile issue.

comment:29 Changed 5 years ago by Raquel Alvarez

  • Status changed from verify to verifying
  • Tester set to Raquel Alvarez

comment:30 Changed 5 years ago by Raquel Alvarez

  • Status changed from verifying to closed

Merge pull request #807 from mantidproject/11829_coverity_reduce_uninit_var_issues_Framework

Reduce coverity "uninitialized..." issues in the component Framework

Full changeset: ​10b4c13e5c6d53d885d833422427d0dfbe1ac9b2

comment:31 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​12667

Note: See TracTickets for help on using tickets.