Ticket #1296 (closed: fixed)

Opened 10 years ago

Last modified 5 years ago

Create alogrithm to read in SNS event preNeXus files

Reported by: Peter Peterson Owned by: Peter Peterson
Priority: major Milestone: Iteration 24
Component: Keywords: event
Cc: Blocked By:
Blocking: Tester: Martyn Gigg

Description

The algorithm should take event filename, pulseid filename (optional), mapping filename (optional means don't map), list of pixels to load (optional, empty means all), list of states to load (optional, empty means all), and output workspace name.

Change History

comment:1 Changed 10 years ago by Peter Peterson

  • Owner set to Peter Peterson
  • Status changed from new to accepted

comment:2 Changed 10 years ago by Peter Peterson

(In [4783]) Just ran the createAlg script to get this and fixed the compilation errors. Refs #1296.

comment:3 Changed 10 years ago by Peter Peterson

(In [4785]) Filled in the init function. Refs #1296.

comment:4 Changed 10 years ago by Peter Peterson

(In [4829]) Checkpointing work. It compiles but there is a runtime error that makes it not work as advertised. Refs #1296.

comment:5 Changed 10 years ago by Peter Peterson

(In [4835]) Finally got the return workspace worked out. Now to add actual functionality. Refs #1296.

comment:6 Changed 10 years ago by Peter Peterson

(In [4842]) Moved the event processing into its own function. Also added functionality to deal with the pixel mapping and generating states. Refs #1296.

comment:7 Changed 10 years ago by Peter Peterson

(In [4849]) Added pixel map reading to the algorithm. Refs #1296.

comment:8 Changed 10 years ago by Janik Zikovsky

(In [4961]) Refs #1296, made a test routine skeleton for testing LoadEventPreNeXus; needs test data files.

comment:9 Changed 10 years ago by Janik Zikovsky

(In [4967]) Refs #1296 - test data for LoadEventPreNexus

comment:10 Changed 10 years ago by Janik Zikovsky

(In [4968]) Refs #1296 - test data for LoadEventPreNexus

comment:11 Changed 10 years ago by Janik Zikovsky

(In [4969]) Refs #1296, test of LoadEventPreNeXus with real data; some fixes to make it run.

comment:12 Changed 10 years ago by Janik Zikovsky

(In [4970]) Refs #1296; temporarily disabled tests to make sure build process completes.

comment:13 Changed 10 years ago by Janik Zikovsky

(In [4973]) Refs #1296; more tests for LoadEventPreNexus.

comment:14 Changed 10 years ago by Peter Peterson

(In [4980]) Adding test data for LoadEventPreNeXus. Refs #1296.

comment:15 Changed 10 years ago by Janik Zikovsky

(In [4981]) Refs #1296; moved test data to same folder.

comment:16 Changed 10 years ago by Janik Zikovsky

(In [4982]) Refs #1296, test added that loads REF_L event data; had to make the pixelmap member public in order to test that functionality.

comment:17 Changed 10 years ago by Janik Zikovsky

(In [4984]) Refs #1296, removed a superfluous include.

comment:18 Changed 10 years ago by Janik Zikovsky

(In [4985]) Refs #1296, removed include that caused Windows build failure

comment:19 Changed 10 years ago by Janik Zikovsky

(In [4987]) Refs #1296; disabled preventnexus tests because they inexplicably fail to build on Windows.

comment:20 Changed 10 years ago by Janik Zikovsky

(In [5000]) Refs #1296; Added DLLExport to hopefully allow build under windows. Also added progress report to SimpleRebin

comment:21 Changed 10 years ago by Peter Peterson

(In [5002]) Added the pulseid file to the REF_L test. Refs #1296.

comment:22 Changed 10 years ago by Janik Zikovsky

(In [5012]) Refs #1296, fix runtests to compile LoadEventPreNexusTest

comment:23 Changed 10 years ago by Janik Zikovsky

(In [5013]) Refs #1296: slight improvement in load event speed. Refs #1267: cleaned up comments of EventList, added AddEventQuickly method.

comment:24 Changed 10 years ago by Janik Zikovsky

(In [5015]) Refs #1296: renamed methods to match coding standards; fixed up comments.

comment:25 Changed 10 years ago by Janik Zikovsky

(In [5020]) Refs #1267 and #1296: more comment clean up, to fix doxygen errors.

comment:26 Changed 10 years ago by Janik Zikovsky

(In [5025]) Refs #1296: more changes to comments to satisfy doxygen.

comment:27 Changed 10 years ago by Peter Peterson

(In [5036]) Set the units on the workspace generated. Refs #1296.

comment:28 Changed 10 years ago by Janik Zikovsky

(In [5049]) Refs #1296: set the default X histogram axis; fixed tof unit conversion. Also Refs #1313: simpleRebin Y unit is copied

comment:29 Changed 10 years ago by Peter Peterson

  • Keywords event added

comment:30 Changed 10 years ago by Peter Peterson

(In [5056]) Defined a constant for the maximum tof as a uint32. Refs #1296.

comment:31 Changed 10 years ago by Peter Peterson

(In [5288]) Do not convert the units on the proton charge log, also log the total proton charge after loading. Refs #1296.

comment:32 Changed 10 years ago by Peter Peterson

(In [5302]) Made the instrument geometry file filter a bit more specifc to reduce the number of files to see in the browser. Refs #1296.

comment:33 Changed 10 years ago by Peter Peterson

(In [5688]) Fixed bug that generated an exception if the instrument geometry file was not found. Refs #1296.

comment:34 Changed 10 years ago by Nick Draper

  • Status changed from accepted to verify

comment:35 Changed 10 years ago by Nick Draper

  • Resolution set to fixed

fill in missing resolution

comment:36 Changed 10 years ago by Martyn Gigg

  • Status changed from verify to verifying
  • Tester set to Martyn Gigg

comment:37 Changed 10 years ago by Martyn Gigg

  • Status changed from verifying to closed

Version [5939]

Tested in conjunction with #1267. All options work as expected.

comment:38 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 2143

Note: See TracTickets for help on using tickets.