Ticket #1334 (closed: wontfix)

Opened 10 years ago

Last modified 5 years ago

Implement HFIR/SANS reduction

Reported by: Mathieu Doucet Owned by: Mathieu Doucet
Priority: major Milestone: Iteration 25
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Stuart Campbell

Description

Use the available set of Mantid algorithms to do reduction of HFIR/SANS data.

Change History

comment:1 Changed 10 years ago by Mathieu Doucet

(In [4928]) Prototype python code for HFIR/SANS reduction [in progress]. Re #1334

comment:2 Changed 10 years ago by Mathieu Doucet

(In [4932]) Additions to HFIR/SANS prototype Re #1334

comment:3 Changed 10 years ago by Mathieu Doucet

(In [4941]) Added notes for HFIR/SANS reduction. Re #1334

comment:4 Changed 10 years ago by Mathieu Doucet

(In [4962]) Minor improvements to HFIR/SANS geometry description. Re #1334

comment:5 Changed 10 years ago by Mathieu Doucet

(In [4986]) Added solid angle correction for SANS reduction as a Mantid Algorithm. Re #1334

comment:6 Changed 10 years ago by Mathieu Doucet

(In [5094]) Added azimuthal averaging with options for pixel weight. Re #1334.

comment:7 Changed 10 years ago by Russell Taylor

(In [5098]) Fix bug causing test crash. Re #1334.

comment:8 Changed 10 years ago by Mathieu Doucet

Russell: Could you be more precise? The logs seem to indicate the same test failures before and after my changes.

comment:9 Changed 10 years ago by Mathieu Doucet

(In [5123]) Added pixel division for Q1DWeighted. Gave test class a more appropriate name. Re #1334.

comment:10 Changed 10 years ago by Mathieu Doucet

(In [5125]) Fix Windows build by explicitly casting input to 'floor'. Re #1334.

comment:11 Changed 10 years ago by Mathieu Doucet

(In [5126]) Add documentation for previously undocumented parameters. Re #1334.

comment:12 Changed 10 years ago by Mathieu Doucet

(In [5132]) Remove meaningless units when loading HFIR/SANS data files. Re #1334.

comment:13 Changed 10 years ago by Mathieu Doucet

(In [5170]) Added beam center finding algorithm as a Mantid Algorithm. Re #1334.

comment:14 Changed 10 years ago by Russell Taylor

(In [5178]) Fix for Windows. Re #1334.

comment:15 Changed 10 years ago by Mathieu Doucet

(In [5191]) Minor clean up. Re #1334.

comment:16 Changed 10 years ago by Mathieu Doucet

(In [5202]) Added CalculateEfficiency and test stub. Minor cleanup to Q1DWeighted. Re #1334

comment:17 Changed 10 years ago by Mathieu Doucet

(In [5204]) Fix problem with CalculateEfficiency test. Re #1334

comment:18 Changed 10 years ago by Mathieu Doucet

(In [5207]) Refactor FindCenterOfMassPosition test, created SANS test instrument workspace helper, and added CalculateEfficiency tests. Re #1334

comment:19 Changed 10 years ago by Mathieu Doucet

(In [5208]) Fix problem with FindCenterOfMassPosition test. Re #1334

comment:20 Changed 10 years ago by Mathieu Doucet

(In [5223]) Modify FindCenterOfMassPosition to be more like fits in CurveFitting and add the option of returning the results using ArrayProperty. Re #1334

comment:21 Changed 10 years ago by Mathieu Doucet

(In [5241]) Added test data for SANS reduction. Re #1334.

comment:22 Changed 10 years ago by Mathieu Doucet

(In [5245]) Updated documentation. Re #1334.

comment:23 Changed 10 years ago by Mathieu Doucet

(In [5246]) Updated python test reduction. Re #1334.

comment:24 Changed 10 years ago by Mathieu Doucet

(In [5250]) Correct FindCenterOfMassPosition algorithm. Re #1334.

comment:25 Changed 10 years ago by Mathieu Doucet

(In [5251]) Updated python test reduction to validate all reduction steps except transmission (includes beam finding algo). Re #1334.

comment:26 Changed 10 years ago by Mathieu Doucet

(In [5297]) Updated HFIR/SANS reduction script. Re #1334

comment:27 Changed 10 years ago by Mathieu Doucet

(In [5311]) Put the validation tests in a separate script. Re #1334.

comment:28 Changed 10 years ago by Mathieu Doucet

(In [5319]) Minor cleanup. Re #1334.

comment:29 Changed 10 years ago by Mathieu Doucet

(In [5969]) Make the normalization the first step in the reduction so that the timer/monitor doesn't get overwritten by other corrections. Re #1334

comment:30 Changed 10 years ago by Mathieu Doucet

  • Status changed from new to verify
  • Resolution set to invalid
  • Component set to Mantid

This ticket is becoming too general. I'm closing it and all further improvements will have their own ticket.

comment:31 Changed 10 years ago by Mathieu Doucet

  • Status changed from verify to reopened
  • Resolution invalid deleted

comment:32 Changed 10 years ago by Mathieu Doucet

  • Status changed from reopened to accepted

comment:33 Changed 10 years ago by Mathieu Doucet

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:34 Changed 10 years ago by Nick Draper

  • Milestone changed from Ongoing to Iteration 25

comment:35 Changed 10 years ago by Janik Zikovsky

  • Status changed from verify to verifying
  • Tester set to Janik Zikovsky

comment:36 Changed 10 years ago by Janik Zikovsky

I go to the Interfaces menu -> HFIR/SANS reduction and I get this error

AttributeError: "'QFile' object has no attribute 'rfind'" in file 'posixpath.py' at line 119

and nothing opens... This is on Ubuntu 10.10, debug compiled version of MantidPlot.

comment:37 Changed 10 years ago by Mathieu Doucet

(In [7160]) Make reduction_application code compatible with python 2.4. Re #1334

comment:38 Changed 10 years ago by Janik Zikovsky

  • Status changed from verifying to verify
  • Tester Janik Zikovsky deleted

There may be some local issue - (did not use installer since I'm on ubuntu) so i'll let someone else test this.

comment:39 Changed 10 years ago by Peter Peterson

  • Status changed from verify to verifying
  • Tester set to Peter Peterson

comment:40 Changed 10 years ago by Peter Peterson

  • Status changed from verifying to reopened
  • Resolution fixed deleted

"Interfaces->HFIR_reduction" still generates the error message:

AttributeError: "'QFile' object has no attribute 'rfind'" in file 'posixpath.py' at line 119

on ubuntu with

>>> print sys.version
2.6.6 (r266:84292, Sep 15 2010, 16:41:53) 
[GCC 4.4.5]

comment:41 Changed 10 years ago by Mathieu Doucet

Which version of PyQt?

comment:42 Changed 10 years ago by Peter Peterson

According to the package manager my version of python-qt4-dev is 4.7.4-0ubuntu1

comment:43 Changed 10 years ago by Peter Peterson

The continuation of this saga is going on #1847.

comment:44 Changed 10 years ago by Mathieu Doucet

  • Status changed from reopened to accepted

comment:45 Changed 10 years ago by Mathieu Doucet

  • Status changed from accepted to verify
  • Resolution set to wontfix

comment:46 Changed 10 years ago by Stuart Campbell

  • Status changed from verify to verifying
  • Tester changed from Peter Peterson to Stuart Campbell

comment:47 Changed 10 years ago by Stuart Campbell

  • Status changed from verifying to closed

Works ok on ubuntu 10.04 which has python-qt4-dev 4.7.2

comment:48 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 2181

Note: See TracTickets for help on using tickets.